Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-06 Thread David Robinson
On March 6, 2014, 12:43 a.m., David Robinson wrote: I added the missing flag instead: https://reviews.apache.org/r/18746/ Would it be worthwhile exposing the feature as a flag in addition to a config option? Brian Wickman wrote: I'm not sure the flag makes sense for the

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/ --- (Updated March 5, 2014, 11:20 p.m.) Review request for Aurora, David Robinson

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/#review36306 --- Ship it! I added the missing flag instead:

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/#review36323 --- Ship it! Ship It! - Brian Wickman On March 5, 2014, 11:20 p.m.,

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread Brian Wickman
On March 6, 2014, 12:43 a.m., David Robinson wrote: I added the missing flag instead: https://reviews.apache.org/r/18746/ Would it be worthwhile exposing the feature as a flag in addition to a config option? I'm not sure the flag makes sense for the restart command, since it doesn't