Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18926/#review36744
---

Ship it!


Ship It!

- Kevin Sweeney


On March 10, 2014, 2 p.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18926/
> ---
> 
> (Updated March 10, 2014, 2 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-102
> https://issues.apache.org/jira/browse/AURORA-102
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Aurora-102: Add failOnVersionConfict() to scheduler build
> 
> Adds resolution strategy to compile time to detect and fail if any dependency
> versions have conflicts.
> 
> 
> Diffs
> -
> 
>   build.gradle 9b8827ea05932620ebac4929838c158e853d73ae 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> 50c76df6cc5f3d6e8072bc23ac6570dda3aabcbd 
> 
> Diff: https://reviews.apache.org/r/18926/diff/
> 
> 
> Testing
> ---
> 
> ran local build with protobuf dependency set to 2.4.1
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Could not resolve all dependencies for configuration ':compile'.
> > A conflict was found between the following modules:
>- com.google.protobuf:protobuf-java:2.4.1
>- com.google.protobuf:protobuf-java:2.5.0
> 
> 
> changed to version 2.5.0
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18926/
---

(Updated March 10, 2014, 9 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Added comments and updated junit version to simplify for upstream fixes on 
dependency collisions later


Bugs: AURORA-102
https://issues.apache.org/jira/browse/AURORA-102


Repository: aurora


Description
---

Aurora-102: Add failOnVersionConfict() to scheduler build

Adds resolution strategy to compile time to detect and fail if any dependency
versions have conflicts.


Diffs (updated)
-

  build.gradle 9b8827ea05932620ebac4929838c158e853d73ae 
  src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
50c76df6cc5f3d6e8072bc23ac6570dda3aabcbd 

Diff: https://reviews.apache.org/r/18926/diff/


Testing
---

ran local build with protobuf dependency set to 2.4.1

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':compile'.
> A conflict was found between the following modules:
   - com.google.protobuf:protobuf-java:2.4.1
   - com.google.protobuf:protobuf-java:2.5.0


changed to version 2.5.0

BUILD SUCCESSFUL


Thanks,

Jake Farrell

Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18926/#review36671
---



build.gradle


should this be prefix, rev?

Also perhaps add a comment explaining why we're stuck on certain versions?


- Kevin Sweeney


On March 10, 2014, 9:22 a.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18926/
> ---
> 
> (Updated March 10, 2014, 9:22 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-102
> https://issues.apache.org/jira/browse/AURORA-102
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Aurora-102: Add failOnVersionConfict() to scheduler build
> 
> Adds resolution strategy to compile time to detect and fail if any dependency
> versions have conflicts.
> 
> 
> Diffs
> -
> 
>   build.gradle 9b8827ea05932620ebac4929838c158e853d73ae 
> 
> Diff: https://reviews.apache.org/r/18926/diff/
> 
> 
> Testing
> ---
> 
> ran local build with protobuf dependency set to 2.4.1
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Could not resolve all dependencies for configuration ':compile'.
> > A conflict was found between the following modules:
>- com.google.protobuf:protobuf-java:2.4.1
>- com.google.protobuf:protobuf-java:2.5.0
> 
> 
> changed to version 2.5.0
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

[Jake Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18926/
---

(Updated March 10, 2014, 4:22 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Updated


Summary (updated)
-

Aurora-102: Add failOnVersionConfict() to scheduler build


Bugs: AURORA-102
https://issues.apache.org/jira/browse/AURORA-102


Repository: aurora


Description (updated)
---

Aurora-102: Add failOnVersionConfict() to scheduler build

Adds resolution strategy to compile time to detect and fail if any dependency
versions have conflicts.


Diffs (updated)
-

  build.gradle 9b8827ea05932620ebac4929838c158e853d73ae 

Diff: https://reviews.apache.org/r/18926/diff/


Testing
---

ran local build with protobuf dependency set to 2.4.1

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':compile'.
> A conflict was found between the following modules:
   - com.google.protobuf:protobuf-java:2.4.1
   - com.google.protobuf:protobuf-java:2.5.0


changed to version 2.5.0

BUILD SUCCESSFUL


Thanks,

Jake Farrell