Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-05-16 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review42417
---



src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh


How about just checking the HTTP response   code is 200 for these 
commands? Checking document length seems brittle.

Something like:

curl -sL -w "%{http_code}" "$base_url/scheduler" -o /dev/null

Will return only the status code.


- David McLaughlin


On April 27, 2014, 2:17 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated April 27, 2014, 2:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> b3292f4ec25936ff6f576518ac9814c14a9610b4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-05-12 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/
---

(Updated May 7, 2014, 4:38 p.m.)


Review request for Aurora, David McLaughlin and Kevin Sweeney.


Changes
---

Rebase to master.


Bugs: aurora-266
https://issues.apache.org/jira/browse/aurora-266


Repository: aurora


Description
---

Add a clientv2 version of the e2e test.


Diffs (updated)
-

  src/main/python/apache/aurora/client/BUILD 
118c4a080b2aac88f1fb6365787b3bb55a665bea 
  src/main/python/apache/aurora/client/cli/BUILD 
8dac98ec1d4438f8a1f23aa5f9b4342de80f3231 
  src/test/python/apache/aurora/client/cli/BUILD 
1504476b5ce288676c0252706fa8c2a411e0f465 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
f89c80183800fbc2cd759b22cddd5a9ea1207636 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/19788/diff/


Testing
---

[sun-wukong incubator-aurora (v2_e2e)]$ sh 
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ . src/test/sh/org/apache/aurora/e2e/test_common.sh
++ exec
++ _aurora_built=false
+ RETCODE=1
+ export CLIENT_NAME=aurorav2.pex
+ CLIENT_NAME=aurorav2.pex
+ export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ TEST_DIR=deploy_test
+ TEST_CLUSTER=example
+ TEST_ROLE=vagrant
+ TEST_ENV=test
+ TEST_JOB=flask_example
+ TEST_SCHEDULER_IP=192.168.33.6
+ TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
$TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
$EXAMPLE_DIR/flask_example_updated.aurora)
+ trap collect_result EXIT
+ vagrant up
Bringing machine 'devtools' up with 'virtualbox' provider...
Bringing machine 'zookeeper' up with 'virtualbox' provider...
Bringing machine 'mesos-master' up with 'virtualbox' provider...
Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
[devtools] VirtualBox VM is already running.
[zookeeper] VirtualBox VM is already running.
[mesos-master] VirtualBox VM is already running.
[mesos-slave1] VirtualBox VM is already running.
[mesos-slave2] VirtualBox VM is already running.
[aurora-scheduler] VirtualBox VM is already running.
+ rm -rf deploy_test
+ devtools_setup deploy_test
+ local _testdir=deploy_test
++ git branch
++ grep '*'
++ cut -c 3-
+ branch=v2_e2e
+ run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
+ vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
~/test_dev; fi'
+ run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
+ vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
HEAD is now at 29ae4e5 end-to-end for clientv2
Removing .BUILD.CPython-2.7.3.pyc
Removing .pants.d/
Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
Removing build-support/pants-0.0.14-dev2.pex
Removing build-support/pex.venv/
Removing build-support/virtualenv-1.10.1.tar.gz
Removing build-support/virtualenv-1.10.1/
Removing dist/
Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
+ run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
+ vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
Already on 'v2_e2e'
>From /vagrant
   29ae4e5..d9cf866  v2_e2e -> origin/v2_e2e
Updating 29ae4e5..d9cf866
Fast-forward
 .../sh/org/apache/aurora/e2e/test_end_to_end_v2.sh |  115 
 1 file changed, 115 insertions(+)
 create mode 100755 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ run_dev 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
+ vagrant ssh devtools -c 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
Building pants.pex @ 0.0.14-de

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-05-11 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/
---

(Updated May 7, 2014, 3:47 p.m.)


Review request for Aurora, David McLaughlin and Kevin Sweeney.


Changes
---

Check http result code instead of curl length.


Bugs: aurora-266
https://issues.apache.org/jira/browse/aurora-266


Repository: aurora


Description
---

Add a clientv2 version of the e2e test.


Diffs (updated)
-

  src/main/python/apache/aurora/client/BUILD 
118c4a080b2aac88f1fb6365787b3bb55a665bea 
  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/test/python/apache/aurora/client/cli/BUILD 
d93a2df0f146e2771de2ce6223438a671d0e92a2 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
b3292f4ec25936ff6f576518ac9814c14a9610b4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/19788/diff/


Testing
---

[sun-wukong incubator-aurora (v2_e2e)]$ sh 
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ . src/test/sh/org/apache/aurora/e2e/test_common.sh
++ exec
++ _aurora_built=false
+ RETCODE=1
+ export CLIENT_NAME=aurorav2.pex
+ CLIENT_NAME=aurorav2.pex
+ export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ TEST_DIR=deploy_test
+ TEST_CLUSTER=example
+ TEST_ROLE=vagrant
+ TEST_ENV=test
+ TEST_JOB=flask_example
+ TEST_SCHEDULER_IP=192.168.33.6
+ TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
$TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
$EXAMPLE_DIR/flask_example_updated.aurora)
+ trap collect_result EXIT
+ vagrant up
Bringing machine 'devtools' up with 'virtualbox' provider...
Bringing machine 'zookeeper' up with 'virtualbox' provider...
Bringing machine 'mesos-master' up with 'virtualbox' provider...
Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
[devtools] VirtualBox VM is already running.
[zookeeper] VirtualBox VM is already running.
[mesos-master] VirtualBox VM is already running.
[mesos-slave1] VirtualBox VM is already running.
[mesos-slave2] VirtualBox VM is already running.
[aurora-scheduler] VirtualBox VM is already running.
+ rm -rf deploy_test
+ devtools_setup deploy_test
+ local _testdir=deploy_test
++ git branch
++ grep '*'
++ cut -c 3-
+ branch=v2_e2e
+ run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
+ vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
~/test_dev; fi'
+ run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
+ vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
HEAD is now at 29ae4e5 end-to-end for clientv2
Removing .BUILD.CPython-2.7.3.pyc
Removing .pants.d/
Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
Removing build-support/pants-0.0.14-dev2.pex
Removing build-support/pex.venv/
Removing build-support/virtualenv-1.10.1.tar.gz
Removing build-support/virtualenv-1.10.1/
Removing dist/
Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
+ run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
+ vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
Already on 'v2_e2e'
>From /vagrant
   29ae4e5..d9cf866  v2_e2e -> origin/v2_e2e
Updating 29ae4e5..d9cf866
Fast-forward
 .../sh/org/apache/aurora/e2e/test_end_to_end_v2.sh |  115 
 1 file changed, 115 insertions(+)
 create mode 100755 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ run_dev 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
+ vagrant ssh devtools -c 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
B

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-05-10 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review42425
---

Ship it!


Ship It!

- David McLaughlin


On May 7, 2014, 7:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated May 7, 2014, 7:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> b3292f4ec25936ff6f576518ac9814c14a9610b4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
> Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
> Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
> + run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
> + vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
> Already on 'v2_e2e'
>

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-27 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/
---

(Updated April 27, 2014, 10:17 a.m.)


Review request for Aurora, David McLaughlin and Kevin Sweeney.


Changes
---

Changed the "people" line to include David. 

David, can you please look at this ASAP? We really want to get a version of 
clientv2 deployed this week, and this is a prereq for that.


Bugs: aurora-266
https://issues.apache.org/jira/browse/aurora-266


Repository: aurora


Description
---

Add a clientv2 version of the e2e test.


Diffs
-

  src/main/python/apache/aurora/client/BUILD 
118c4a080b2aac88f1fb6365787b3bb55a665bea 
  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/test/python/apache/aurora/client/cli/BUILD 
d93a2df0f146e2771de2ce6223438a671d0e92a2 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
b3292f4ec25936ff6f576518ac9814c14a9610b4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/19788/diff/


Testing
---

[sun-wukong incubator-aurora (v2_e2e)]$ sh 
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ . src/test/sh/org/apache/aurora/e2e/test_common.sh
++ exec
++ _aurora_built=false
+ RETCODE=1
+ export CLIENT_NAME=aurorav2.pex
+ CLIENT_NAME=aurorav2.pex
+ export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ TEST_DIR=deploy_test
+ TEST_CLUSTER=example
+ TEST_ROLE=vagrant
+ TEST_ENV=test
+ TEST_JOB=flask_example
+ TEST_SCHEDULER_IP=192.168.33.6
+ TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
$TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
$EXAMPLE_DIR/flask_example_updated.aurora)
+ trap collect_result EXIT
+ vagrant up
Bringing machine 'devtools' up with 'virtualbox' provider...
Bringing machine 'zookeeper' up with 'virtualbox' provider...
Bringing machine 'mesos-master' up with 'virtualbox' provider...
Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
[devtools] VirtualBox VM is already running.
[zookeeper] VirtualBox VM is already running.
[mesos-master] VirtualBox VM is already running.
[mesos-slave1] VirtualBox VM is already running.
[mesos-slave2] VirtualBox VM is already running.
[aurora-scheduler] VirtualBox VM is already running.
+ rm -rf deploy_test
+ devtools_setup deploy_test
+ local _testdir=deploy_test
++ git branch
++ grep '*'
++ cut -c 3-
+ branch=v2_e2e
+ run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
+ vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
~/test_dev; fi'
+ run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
+ vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
HEAD is now at 29ae4e5 end-to-end for clientv2
Removing .BUILD.CPython-2.7.3.pyc
Removing .pants.d/
Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
Removing build-support/pants-0.0.14-dev2.pex
Removing build-support/pex.venv/
Removing build-support/virtualenv-1.10.1.tar.gz
Removing build-support/virtualenv-1.10.1/
Removing dist/
Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
+ run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
+ vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
Already on 'v2_e2e'
>From /vagrant
   29ae4e5..d9cf866  v2_e2e -> origin/v2_e2e
Updating 29ae4e5..d9cf866
Fast-forward
 .../sh/org/apache/aurora/e2e/test_end_to_end_v2.sh |  115 
 1 file changed, 115 insertions(+)
 create mode 100755 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ run_dev 'cd ~/test_dev; ./pants 
src/main/python/apache/a

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-21 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/
---

(Updated April 21, 2014, 10:57 a.m.)


Review request for Aurora, Joe Smith and Kevin Sweeney.


Changes
---

Address kevin's naming comments.


Bugs: aurora-266
https://issues.apache.org/jira/browse/aurora-266


Repository: aurora


Description
---

Add a clientv2 version of the e2e test.


Diffs (updated)
-

  src/main/python/apache/aurora/client/BUILD 
118c4a080b2aac88f1fb6365787b3bb55a665bea 
  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/test/python/apache/aurora/client/cli/BUILD 
d93a2df0f146e2771de2ce6223438a671d0e92a2 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
b3292f4ec25936ff6f576518ac9814c14a9610b4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/19788/diff/


Testing
---

[sun-wukong incubator-aurora (v2_e2e)]$ sh 
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ . src/test/sh/org/apache/aurora/e2e/test_common.sh
++ exec
++ _aurora_built=false
+ RETCODE=1
+ export CLIENT_NAME=aurorav2.pex
+ CLIENT_NAME=aurorav2.pex
+ export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ TEST_DIR=deploy_test
+ TEST_CLUSTER=example
+ TEST_ROLE=vagrant
+ TEST_ENV=test
+ TEST_JOB=flask_example
+ TEST_SCHEDULER_IP=192.168.33.6
+ TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
$TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
$EXAMPLE_DIR/flask_example_updated.aurora)
+ trap collect_result EXIT
+ vagrant up
Bringing machine 'devtools' up with 'virtualbox' provider...
Bringing machine 'zookeeper' up with 'virtualbox' provider...
Bringing machine 'mesos-master' up with 'virtualbox' provider...
Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
[devtools] VirtualBox VM is already running.
[zookeeper] VirtualBox VM is already running.
[mesos-master] VirtualBox VM is already running.
[mesos-slave1] VirtualBox VM is already running.
[mesos-slave2] VirtualBox VM is already running.
[aurora-scheduler] VirtualBox VM is already running.
+ rm -rf deploy_test
+ devtools_setup deploy_test
+ local _testdir=deploy_test
++ git branch
++ grep '*'
++ cut -c 3-
+ branch=v2_e2e
+ run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
+ vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
~/test_dev; fi'
+ run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
+ vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
HEAD is now at 29ae4e5 end-to-end for clientv2
Removing .BUILD.CPython-2.7.3.pyc
Removing .pants.d/
Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
Removing build-support/pants-0.0.14-dev2.pex
Removing build-support/pex.venv/
Removing build-support/virtualenv-1.10.1.tar.gz
Removing build-support/virtualenv-1.10.1/
Removing dist/
Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
+ run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
+ vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
Already on 'v2_e2e'
>From /vagrant
   29ae4e5..d9cf866  v2_e2e -> origin/v2_e2e
Updating 29ae4e5..d9cf866
Fast-forward
 .../sh/org/apache/aurora/e2e/test_end_to_end_v2.sh |  115 
 1 file changed, 115 insertions(+)
 create mode 100755 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ run_dev 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
+ vagrant ssh devtools -c 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
Building pants.pex

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-08 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review39847
---

Ship it!



src/main/python/apache/aurora/client/BUILD


This target name actually influences what a pip-installed 
apache.aurora.clientv2 will be called, consider changing it to "aurora2"



src/main/python/apache/aurora/client/BUILD


This target name actually influences what a pip-installed 
apache.aurora.clientv2 will install into bin/, consider changing it to "aurora2"



src/main/python/apache/aurora/client/cli/BUILD


Maybe just name it aurora2?



src/main/python/apache/aurora/client/cli/BUILD


Maybe just name it aurora2?


- Kevin Sweeney


On April 2, 2014, 6:40 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated April 2, 2014, 6:40 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> b3292f4ec25936ff6f576518ac9814c14a9610b4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apac

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-07 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review39685
---


ping?

- Mark Chu-Carroll


On April 2, 2014, 9:40 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated April 2, 2014, 9:40 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> b3292f4ec25936ff6f576518ac9814c14a9610b4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
> Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
> Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
> + run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
> + vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
> Already on 'v2_e2e'
> From /vagrant
>

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-02 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/
---

(Updated April 2, 2014, 9:40 a.m.)


Review request for Aurora, Joe Smith and Kevin Sweeney.


Changes
---

Address maxim's review.


Bugs: aurora-266
https://issues.apache.org/jira/browse/aurora-266


Repository: aurora


Description
---

Add a clientv2 version of the e2e test.


Diffs (updated)
-

  src/main/python/apache/aurora/client/BUILD 
118c4a080b2aac88f1fb6365787b3bb55a665bea 
  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/test/python/apache/aurora/client/cli/BUILD 
d93a2df0f146e2771de2ce6223438a671d0e92a2 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
b3292f4ec25936ff6f576518ac9814c14a9610b4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/19788/diff/


Testing
---

[sun-wukong incubator-aurora (v2_e2e)]$ sh 
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ . src/test/sh/org/apache/aurora/e2e/test_common.sh
++ exec
++ _aurora_built=false
+ RETCODE=1
+ export CLIENT_NAME=aurorav2.pex
+ CLIENT_NAME=aurorav2.pex
+ export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
+ TEST_DIR=deploy_test
+ TEST_CLUSTER=example
+ TEST_ROLE=vagrant
+ TEST_ENV=test
+ TEST_JOB=flask_example
+ TEST_SCHEDULER_IP=192.168.33.6
+ TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
$TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
$EXAMPLE_DIR/flask_example_updated.aurora)
+ trap collect_result EXIT
+ vagrant up
Bringing machine 'devtools' up with 'virtualbox' provider...
Bringing machine 'zookeeper' up with 'virtualbox' provider...
Bringing machine 'mesos-master' up with 'virtualbox' provider...
Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
[devtools] VirtualBox VM is already running.
[zookeeper] VirtualBox VM is already running.
[mesos-master] VirtualBox VM is already running.
[mesos-slave1] VirtualBox VM is already running.
[mesos-slave2] VirtualBox VM is already running.
[aurora-scheduler] VirtualBox VM is already running.
+ rm -rf deploy_test
+ devtools_setup deploy_test
+ local _testdir=deploy_test
++ git branch
++ grep '*'
++ cut -c 3-
+ branch=v2_e2e
+ run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
+ vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
~/test_dev; fi'
+ run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
+ vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
HEAD is now at 29ae4e5 end-to-end for clientv2
Removing .BUILD.CPython-2.7.3.pyc
Removing .pants.d/
Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
Removing build-support/pants-0.0.14-dev2.pex
Removing build-support/pex.venv/
Removing build-support/virtualenv-1.10.1.tar.gz
Removing build-support/virtualenv-1.10.1/
Removing dist/
Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc
Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc
Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc
Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc
+ run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull'
+ vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull'
Already on 'v2_e2e'
>From /vagrant
   29ae4e5..d9cf866  v2_e2e -> origin/v2_e2e
Updating 29ae4e5..d9cf866
Fast-forward
 .../sh/org/apache/aurora/e2e/test_end_to_end_v2.sh |  115 
 1 file changed, 115 insertions(+)
 create mode 100755 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
+ run_dev 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
+ vagrant ssh devtools -c 'cd ~/test_dev; ./pants 
src/main/python/apache/aurora/client/cli:aurorav2'
Building pants.pex @ 0.0.14-d

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-01 Thread Mark Chu-Carroll 


> On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43
> > 
> >
> > Why not pushd once instead?
> 
> Mark Chu-Carroll wrote:
> Don't follow the question. What would a pushd accomplish here?
> 
> Maxim Khutornenko wrote:
> Sorry, what I meant here ssh, pushd and do everything in a single session.

We get better errors this way. Right now, when the test setup fails, you can 
easily see exactly which step was the problem. When you bundle it into one 
session, it becomes harder. The time-cost of doing it this way is under 2 
seconds, which is pretty much noise in the runtime of this test.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review38919
---


On March 28, 2014, 1:28 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated March 28, 2014, 1:28 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-01 Thread Maxim Khutornenko 


> On March 28, 2014, 5:46 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43
> > 
> >
> > Why not pushd once instead?
> 
> Mark Chu-Carroll wrote:
> Don't follow the question. What would a pushd accomplish here?

Sorry, what I meant here ssh, pushd and do everything in a single session.


> On March 28, 2014, 5:46 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 109
> > 
> >
> > How about adding a check here to see that all instances are up (e.g. 
> > ping)? Otherwise, test hangs will be a common problem. Had that experience 
> > with ZK down before.
> 
> Mark Chu-Carroll wrote:
> In my experience, "vagrant up" will fail if the instances don't come up; 
> that will trigger a test failure, won't it?
> 
> (The problem with pinging is that in our setup, the machine doesn't have 
> a DNS entry on the machine running the test. So you can either ping an IP 
> address - in which case, changing the vagrant file will make this test fail; 
> or you can ping from one of the virtual machines - but then, you've got the 
> same potential hang problem as not pinging at all.)

The idea I tried to suggest here is to do something like ping to check the 
machines are up and fail fast otherwise. I had cases where ZK was up as per 
vagrant but was not responsive at all. Any attempt to call it resulted in a 
hang. 

Anyway, feel free to ignore it as with Bill's refactoring we would have less 
moving parts to worry about. 


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review38919
---


On March 28, 2014, 5:28 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated March 28, 2014, 5:28 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Rem

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-01 Thread Mark Chu-Carroll 


> On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43
> > 
> >
> > Why not pushd once instead?

Don't follow the question. What would a pushd accomplish here?


> On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 109
> > 
> >
> > How about adding a check here to see that all instances are up (e.g. 
> > ping)? Otherwise, test hangs will be a common problem. Had that experience 
> > with ZK down before.

In my experience, "vagrant up" will fail if the instances don't come up; that 
will trigger a test failure, won't it?

(The problem with pinging is that in our setup, the machine doesn't have a DNS 
entry on the machine running the test. So you can either ping an IP address - 
in which case, changing the vagrant file will make this test fail; or you can 
ping from one of the virtual machines - but then, you've got the same potential 
hang problem as not pinging at all.)


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review38919
---


On March 28, 2014, 1:28 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated March 28, 2014, 1:28 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-03-28 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review38919
---



src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh


"git rev-parse --abbrev-ref HEAD" will do just what you want without 
cutting.



src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh


Why not pushd once instead?



src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh


How about adding a check here to see that all instances are up (e.g. ping)? 
Otherwise, test hangs will be a common problem. Had that experience with ZK 
down before.


- Maxim Khutornenko


On March 28, 2014, 5:28 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated March 28, 2014, 5:28 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apac