Re: Review Request 19958: Revert "AURORA-29: Clean up resource files under src/resources/org/apache/"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/#review41679 --- Ship it! Anything blocking committing this? and do we want to look at possibly moving this to src/test/resources or maybe generating this rather than having direct files committed? - Jake Farrell On April 2, 2014, 8:49 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19958/ > --- > > (Updated April 2, 2014, 8:49 p.m.) > > > Review request for Aurora, Dan Norris and Bill Farner. > > > Bugs: AURORA-14 > https://issues.apache.org/jira/browse/AURORA-14 > > > Repository: aurora > > > Description > --- > > Revert "AURORA-29: Clean up resource files under src/resources/org/apache/" > > This reverts commit ad35931b2540372b5449ec5083b6473c4a61dfd1. > > > Diffs > - > > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p1 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p2 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p3 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.a > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.b > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure_limit/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/hello_world/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/hello_world/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_one > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_three > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_two > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ordering/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/runner PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/runner > PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p1/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/2/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure_limit/a/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/hello_world/echo/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_one/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p1 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p2 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p3 PRE-CREATION > src/resources/org/apache/thermos/root/tasks/active/sleep60-lost > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure_limit > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/hello_world > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ordering PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ports PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/sleep60 PRE-CREATION > > Diff: https://reviews.apache.org/r/19958/diff/ > > > Testing > --- > > ./pants src/test/python/apache/aurora/executor:executor-large -vxs > > ... > > > === 15 passed in > 42.15 seconds =
Re: Review Request 19958: Revert "AURORA-29: Clean up resource files under src/resources/org/apache/"
> On April 2, 2014, 9:03 p.m., Bill Farner wrote: > > Can you follow up on AURORA-14 to help make progress? At four months in, > > it's starting to look like this is our permanent state. Whoops, i neglected to spot https://reviews.apache.org/r/19955/ Thanks!! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/#review39354 --- On April 2, 2014, 8:49 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19958/ > --- > > (Updated April 2, 2014, 8:49 p.m.) > > > Review request for Aurora, Dan Norris and Bill Farner. > > > Bugs: AURORA-14 > https://issues.apache.org/jira/browse/AURORA-14 > > > Repository: aurora > > > Description > --- > > Revert "AURORA-29: Clean up resource files under src/resources/org/apache/" > > This reverts commit ad35931b2540372b5449ec5083b6473c4a61dfd1. > > > Diffs > - > > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p1 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p2 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p3 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.a > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.b > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure_limit/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/hello_world/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/hello_world/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_one > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_three > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_two > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ordering/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/runner PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/runner > PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p1/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/2/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure_limit/a/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/hello_world/echo/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_one/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p1 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p2 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p3 PRE-CREATION > src/resources/org/apache/thermos/root/tasks/active/sleep60-lost > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure_limit > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/hello_world > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ordering PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ports PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/sleep60 PRE-CREATION > > Diff: https://reviews.apache.org/r/19958/diff/ > > > Testing > --- > > ./pants src/test/python/apache/aurora/executor:executor-large -vxs > > ... > > > =
Re: Review Request 19958: Revert "AURORA-29: Clean up resource files under src/resources/org/apache/"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/#review39355 --- Ship it! Ship It! - Dan Norris On April 2, 2014, 8:49 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19958/ > --- > > (Updated April 2, 2014, 8:49 p.m.) > > > Review request for Aurora, Dan Norris and Bill Farner. > > > Bugs: AURORA-14 > https://issues.apache.org/jira/browse/AURORA-14 > > > Repository: aurora > > > Description > --- > > Revert "AURORA-29: Clean up resource files under src/resources/org/apache/" > > This reverts commit ad35931b2540372b5449ec5083b6473c4a61dfd1. > > > Diffs > - > > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p1 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p2 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p3 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.a > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.b > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure_limit/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/hello_world/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/hello_world/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_one > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_three > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_two > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ordering/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/runner PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/runner > PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p1/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/2/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure_limit/a/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/hello_world/echo/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_one/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p1 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p2 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p3 PRE-CREATION > src/resources/org/apache/thermos/root/tasks/active/sleep60-lost > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure_limit > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/hello_world > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ordering PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ports PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/sleep60 PRE-CREATION > > Diff: https://reviews.apache.org/r/19958/diff/ > > > Testing > --- > > ./pants src/test/python/apache/aurora/executor:executor-large -vxs > > ... > > > === 15 passed in > 42.15 seconds === > Writing log files to disk in > /var/folders/4d/9tz0cd5n2n7947xs21gspsxcgp/T/tmpyFCRNS > src.test.python.apache.au
Re: Review Request 19958: Revert "AURORA-29: Clean up resource files under src/resources/org/apache/"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/#review39354 --- Ship it! Can you follow up on AURORA-14 to help make progress? At four months in, it's starting to look like this is our permanent state. - Bill Farner On April 2, 2014, 8:49 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19958/ > --- > > (Updated April 2, 2014, 8:49 p.m.) > > > Review request for Aurora, Dan Norris and Bill Farner. > > > Bugs: AURORA-14 > https://issues.apache.org/jira/browse/AURORA-14 > > > Repository: aurora > > > Description > --- > > Revert "AURORA-29: Clean up resource files under src/resources/org/apache/" > > This reverts commit ad35931b2540372b5449ec5083b6473c4a61dfd1. > > > Diffs > - > > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p1 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p2 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p3 > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.a > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.b > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/failure_limit/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/hello_world/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/hello_world/runner > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_one > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_three > PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_two > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ordering/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/coordinator.echo > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/ports/runner PRE-CREATION > > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/runner > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/coordinator.sleep > PRE-CREATION > src/resources/org/apache/thermos/root/checkpoints/sleep60/runner > PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p1/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p2/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/1/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure/p3/2/stdout PRE-CREATION > src/resources/org/apache/thermos/root/logs/failure_limit/a/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/hello_world/echo/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_one/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout > PRE-CREATION > src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p1 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p2 PRE-CREATION > src/resources/org/apache/thermos/root/sandbox/p3 PRE-CREATION > src/resources/org/apache/thermos/root/tasks/active/sleep60-lost > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/failure_limit > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/hello_world > PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ordering PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/ports PRE-CREATION > src/resources/org/apache/thermos/root/tasks/finished/sleep60 PRE-CREATION > > Diff: https://reviews.apache.org/r/19958/diff/ > > > Testing > --- > > ./pants src/test/python/apache/aurora/executor:executor-large -vxs > > ... > > > === 15 passed in > 42.15 seconds =
