Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20066/ --- (Updated April 7, 2014, 3:07 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20066/#review39737 --- src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java

Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20066/#review39741 --- Ship it! Ship It! - Kevin Sweeney On April 7, 2014, 8:07 a.m.,

Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-07 Thread Bill Farner
On April 7, 2014, 11:07 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java, line 62 https://reviews.apache.org/r/20066/diff/3/?file=550680#file550680line62 What does synchronized add here? As far as I can tell this value is immutable.

Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20066/ --- (Updated April 6, 2014, 7:29 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20066/ --- (Updated April 6, 2014, 7:40 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 20066: Remove duplicate task throttling behavior from TaskGroups, fix a few race conditions.

2014-04-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20066/#review39653 --- Ship it!