Re: Review Request 20726: Removing client HTTP health checks.

2014-04-28 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/#review41671
---

Ship it!


Ship It!

- Brian Wickman


On April 25, 2014, 7:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20726/
> ---
> 
> (Updated April 25, 2014, 7:41 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-361
> https://issues.apache.org/jira/browse/AURORA-361
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping client http health checks in favor of status checks only.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/health_check.py 
> e3bbf71a37c3137d580378ac185eaf65f4b056af 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> 530868348142c73708fa7f0d7296a3fb5b6ebb5d 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> f59fe42cc4808aeece34f55978ca34e62404ac58 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 43412c44edba19e8c7d753118d7ad0be78a4fd39 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> e3e433262f354ed0573273bd0c28746c3cef902b 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> 526c501869b7ae22550e5d84613ca38f8071b9b7 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> f90783779805313f529487509f7d457ba8ee138c 
> 
> Diff: https://reviews.apache.org/r/20726/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 20726: Removing client HTTP health checks.

2014-04-28 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/#review41649
---


Ping, Brian.

- Maxim Khutornenko


On April 25, 2014, 7:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20726/
> ---
> 
> (Updated April 25, 2014, 7:41 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-361
> https://issues.apache.org/jira/browse/AURORA-361
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping client http health checks in favor of status checks only.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/health_check.py 
> e3bbf71a37c3137d580378ac185eaf65f4b056af 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> 530868348142c73708fa7f0d7296a3fb5b6ebb5d 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> f59fe42cc4808aeece34f55978ca34e62404ac58 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 43412c44edba19e8c7d753118d7ad0be78a4fd39 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> e3e433262f354ed0573273bd0c28746c3cef902b 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> 526c501869b7ae22550e5d84613ca38f8071b9b7 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> f90783779805313f529487509f7d457ba8ee138c 
> 
> Diff: https://reviews.apache.org/r/20726/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 20726: Removing client HTTP health checks.

2014-04-25 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/#review41515
---

Ship it!


Ship It!

- Mark Chu-Carroll


On April 25, 2014, 3:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20726/
> ---
> 
> (Updated April 25, 2014, 3:41 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-361
> https://issues.apache.org/jira/browse/AURORA-361
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping client http health checks in favor of status checks only.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/health_check.py 
> e3bbf71a37c3137d580378ac185eaf65f4b056af 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> 530868348142c73708fa7f0d7296a3fb5b6ebb5d 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> f59fe42cc4808aeece34f55978ca34e62404ac58 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 43412c44edba19e8c7d753118d7ad0be78a4fd39 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> e3e433262f354ed0573273bd0c28746c3cef902b 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> 526c501869b7ae22550e5d84613ca38f8071b9b7 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> f90783779805313f529487509f7d457ba8ee138c 
> 
> Diff: https://reviews.apache.org/r/20726/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>