Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/#review42832 --- Suman, ping? - Mark Chu-Carroll On May 8, 2014, 10:26 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/ --- (Updated May 8, 2014, 10:26 a.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-399 https://issues.apache.org/jira/browse/aurora-399 Repository: aurora Description --- Bugfix: restart doesn't notify user about invalid max_total_failures option. Diffs - src/main/python/apache/aurora/client/cli/jobs.py cf45640a66c76ae4daa0ceaa3ff8da80c4cbe91d src/main/python/apache/aurora/client/commands/core.py 0046c7686261ec11c2064348e21a35758b449d27 src/test/python/apache/aurora/client/cli/test_restart.py 9b7a2c69b53d4be35587f630f429943a4907b74b src/test/python/apache/aurora/client/commands/test_restart.py 9af6334264f40cbccbef545bd15ffa85171ad348 Diff: https://reviews.apache.org/r/21205/diff/ Testing --- [sun-wukong incubator-aurora (restart_max)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.36 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.45 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.41 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/api/test_job_monitor.py === 4 passed in 0.39 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.34 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 4.05 seconds == == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py === 12 passed in 0.22 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 28 items src/test/python/apache/aurora/client/api/test_updater.py === 28 passed in 0.67 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. === 6 passed in 0.14 seconds
Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/#review42588 --- Ship it! src/test/python/apache/aurora/client/cli/test_restart.py https://reviews.apache.org/r/21205/#comment76401 checkstyle: extra newline - David McLaughlin On May 8, 2014, 2:26 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/ --- (Updated May 8, 2014, 2:26 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-399 https://issues.apache.org/jira/browse/aurora-399 Repository: aurora Description --- Bugfix: restart doesn't notify user about invalid max_total_failures option. Diffs - src/main/python/apache/aurora/client/cli/jobs.py cf45640a66c76ae4daa0ceaa3ff8da80c4cbe91d src/main/python/apache/aurora/client/commands/core.py 0046c7686261ec11c2064348e21a35758b449d27 src/test/python/apache/aurora/client/cli/test_restart.py 9b7a2c69b53d4be35587f630f429943a4907b74b src/test/python/apache/aurora/client/commands/test_restart.py 9af6334264f40cbccbef545bd15ffa85171ad348 Diff: https://reviews.apache.org/r/21205/diff/ Testing --- [sun-wukong incubator-aurora (restart_max)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.36 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.45 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.41 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/api/test_job_monitor.py === 4 passed in 0.39 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.34 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 4.05 seconds == == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py === 12 passed in 0.22 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 28 items src/test/python/apache/aurora/client/api/test_updater.py === 28 passed in 0.67 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items
