Re: Review Request 21402: Add python checkstyle hooks.

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/#review46638 --- Ship it! Looks good, please create a ticket to capture the log outp

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-19 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/#review43400 --- Ship it! Looks good, thoughts on saving the output to a build log f

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-19 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/#review43389 --- Ship it! Ship It! - Kevin Sweeney On May 13, 2014, 1:04 p.m., Br

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-19 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/#review43367 --- Ship it! Ship It! - Joe Smith On May 13, 2014, 1:04 p.m., Brian

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-16 Thread Brian Wickman
> On May 15, 2014, 2:01 a.m., Dan Norris wrote: > > build-support/python/checkstyle-check, line 23 > > > > > > Could you consolidate checkstyle and checkstyle check by sourcing the > > venv and calling deactivate once

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-16 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/#review43078 --- build-support/python/checkstyle-check

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-13 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/ --- (Updated May 13, 2014, 8:04 p.m.) Review request for Aurora, Jake Farrell and K