Re: Review Request 21662: Move the cron summary underneath the config summary

2014-05-20 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21662/#review43568
---

Ship it!


Ship It!

- Mark Chu-Carroll


On May 19, 2014, 5:24 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21662/
> ---
> 
> (Updated May 19, 2014, 5:24 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-450
> https://issues.apache.org/jira/browse/AURORA-450
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move the cron summary underneath the config summary
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> 8437d3008d310261ec0b02e62dd13c64ee5dcc4f 
> 
> Diff: https://reviews.apache.org/r/21662/diff/
> 
> 
> Testing
> ---
> 
> Ran locally.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2014-05-19 at 2.24.30 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/19/00d7bd0c-6c8f-4932-aaea-abbea7d54d36__Screen_Shot_2014-05-19_at_2.24.30_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 21662: Move the cron summary underneath the config summary

2014-05-20 Thread Suman Karumuri


> On May 20, 2014, 5:44 p.m., Suman Karumuri wrote:
> > Why?

Sorry just saw the ticket. Commenting there.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21662/#review43502
---


On May 19, 2014, 9:24 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21662/
> ---
> 
> (Updated May 19, 2014, 9:24 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-450
> https://issues.apache.org/jira/browse/AURORA-450
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move the cron summary underneath the config summary
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> 8437d3008d310261ec0b02e62dd13c64ee5dcc4f 
> 
> Diff: https://reviews.apache.org/r/21662/diff/
> 
> 
> Testing
> ---
> 
> Ran locally.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2014-05-19 at 2.24.30 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/19/00d7bd0c-6c8f-4932-aaea-abbea7d54d36__Screen_Shot_2014-05-19_at_2.24.30_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 21662: Move the cron summary underneath the config summary

2014-05-20 Thread Suman Karumuri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21662/#review43502
---


Why?

- Suman Karumuri


On May 19, 2014, 9:24 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21662/
> ---
> 
> (Updated May 19, 2014, 9:24 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-450
> https://issues.apache.org/jira/browse/AURORA-450
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move the cron summary underneath the config summary
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> 8437d3008d310261ec0b02e62dd13c64ee5dcc4f 
> 
> Diff: https://reviews.apache.org/r/21662/diff/
> 
> 
> Testing
> ---
> 
> Ran locally.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2014-05-19 at 2.24.30 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/19/00d7bd0c-6c8f-4932-aaea-abbea7d54d36__Screen_Shot_2014-05-19_at_2.24.30_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>