Re: Review Request 21754: Add PMD to the build.

2014-05-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21754/#review43646 --- Ship it! Ship It! - David McLaughlin On May 21, 2014, 6:05 a.m.,

Re: Review Request 21754: Add PMD to the build.

2014-05-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21754/#review43625 --- Ship it! lgtm - Maxim Khutornenko On May 21, 2014, 6:05 a.m., Bi

Re: Review Request 21754: Add PMD to the build.

2014-05-21 Thread Bill Farner
> On May 21, 2014, 3:01 p.m., Maxim Khutornenko wrote: > > Does it bring anything else besides parentheses checks that findbugs does > > not already do? My only concern is build performance. That said, if it does > > not take long to run I am in. > > Bill Farner wrote: > http://lmgtfy.com/

Re: Review Request 21754: Add PMD to the build.

2014-05-21 Thread Bill Farner
> On May 21, 2014, 3:01 p.m., Maxim Khutornenko wrote: > > Does it bring anything else besides parentheses checks that findbugs does > > not already do? My only concern is build performance. That said, if it does > > not take long to run I am in. http://lmgtfy.com/?q=difference+between+findbug

Re: Review Request 21754: Add PMD to the build.

2014-05-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21754/#review43617 --- Does it bring anything else besides parentheses checks that findbugs