Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43972 --- Ship it! Ship It! - Mark Chu-Carroll On May 23, 2014, 3:30

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43977 --- src/main/java/org/apache/aurora/scheduler/thrift/Util.java

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 27, 2014, 5:39 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Mark Chu-Carroll
On May 27, 2014, 12:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Maxim Khutornenko
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 49 https://reviews.apache.org/r/21830/diff/2/?file=590896#file590896line49 We don't inline @Inject with methods, why here? Bill Farner wrote:

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Maxim Khutornenko
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 27, 2014, 11 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner
On May 23, 2014, 12:07 a.m., Maxim Khutornenko wrote: This will not pass python tests as we reference resp.message in quite a few places. Doh! You're right, i published this in haste before leaving the office. I'll fix that up shortly. - Bill

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 23, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43868 --- Also passes old and new end-to-end tests. - Bill Farner On May

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43870 --- Ship it! Ship It! - David McLaughlin On May 23, 2014, 7:30

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43796 --- This will not pass python tests as we reference resp.message in

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43801 --- Ship it! Looks great; thanks for doing this so quickly! - Mark