Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43972
---

Ship it!


Ship It!

- Mark Chu-Carroll


On May 23, 2014, 3:30 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 23, 2014, 3:30 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  88bd20d55b488b30dba70d8c1469e058d1c761bc 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  2134609769d74755d11b43015bd1d17ad49132ec 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 ee22af10a469db1a3cc46d9092285977b5526f9e 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
   src/main/python/apache/aurora/client/api/__init__.py 
 f671ed860eee6ce57e4fee5e4ebbfb926fc2b3ae 
   src/main/python/apache/aurora/client/api/command_runner.py 
 c1459c4ba8553d82b9d9d1fdbf674f45006ca96c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 8992b93d25ce71b5784bad24429fd32356f64763 
   src/main/python/apache/aurora/client/api/quota_check.py 
 cfb56d7ae7e0f138c541b3125f27f010c0fe6c2a 
   src/main/python/apache/aurora/client/api/restarter.py 
 bceba63efd6e3ed198d3bdd041c8c961aa9c98c6 
   src/main/python/apache/aurora/client/api/updater.py 
 e8692ea4fdf924fb1ea06803d5e7321340754442 
   src/main/python/apache/aurora/client/base.py 
 cc08c18b1c4e664ca38efccca7f6d96a070479ba 
   src/main/python/apache/aurora/client/cli/context.py 
 fae30f6fc829699b6d775bce3fff1be3cde3dd65 
   src/main/python/apache/aurora/client/cli/jobs.py 
 c318926439dba2c99a4a34c153c8d3d0bef17207 
   src/main/python/apache/aurora/client/cli/task.py 
 1bd746da2f39f78b1497701f69777ca3ea6b70ea 
   src/main/python/apache/aurora/client/commands/admin.py 
 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 
   src/main/python/apache/aurora/client/commands/core.py 
 9b4c76a57eb7cb99a024febc5623606389fe7557 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 0568d91b4b13d8e3891eef2ce908d632e0402fa8 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  a9e5d89465a14c0d8bd4540b34e311763357f78f 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9fe47ae248473cccb42730c458d199219b1ffe7 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 09dda3bed6a5097f6dff8153249a7460a5b24d58 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3df042019d845421e5c8d79232ed865e342d44fc 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 854a98c9afe8e265a8794cbe6f9dc8af07181394 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 807994502a7f265bf4aae9b4af7ba77a2c3a9ace 
   src/test/python/apache/aurora/client/api/test_sla.py 
 02b36d5cd3322f6f03f1d6d525745faf2513f065 
   src/test/python/apache/aurora/client/api/test_updater.py 
 03a14186646daede689ac77e2ab7144aa5a7fa14 
   src/test/python/apache/aurora/client/cli/util.py 
 ccb6ea51eb636c2c564a0ee1a0ba2d41707bd2ca 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 bc3b92bdfc7838b6a0671078ef315ccd707eb5a5 
   src/test/python/apache/aurora/client/commands/util.py 
 4e587f320c785b56f5812364d50946cb2b6f03dc 
 
 Diff: https://reviews.apache.org/r/21830/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---



src/main/java/org/apache/aurora/scheduler/thrift/Util.java
https://reviews.apache.org/r/21830/#comment78221

s/too/to



src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java
https://reviews.apache.org/r/21830/#comment78222

We don't inline @Inject with methods, why here?



src/main/thrift/org/apache/aurora/gen/api.thrift
https://reviews.apache.org/r/21830/#comment78223

Would it make sense to change it to list instead? I can imagine how the 
order may be helpful here in troubleshooting multi-message errors. 


- Maxim Khutornenko


On May 23, 2014, 7:30 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 23, 2014, 7:30 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  88bd20d55b488b30dba70d8c1469e058d1c761bc 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  2134609769d74755d11b43015bd1d17ad49132ec 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 ee22af10a469db1a3cc46d9092285977b5526f9e 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
   src/main/python/apache/aurora/client/api/__init__.py 
 f671ed860eee6ce57e4fee5e4ebbfb926fc2b3ae 
   src/main/python/apache/aurora/client/api/command_runner.py 
 c1459c4ba8553d82b9d9d1fdbf674f45006ca96c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 8992b93d25ce71b5784bad24429fd32356f64763 
   src/main/python/apache/aurora/client/api/quota_check.py 
 cfb56d7ae7e0f138c541b3125f27f010c0fe6c2a 
   src/main/python/apache/aurora/client/api/restarter.py 
 bceba63efd6e3ed198d3bdd041c8c961aa9c98c6 
   src/main/python/apache/aurora/client/api/updater.py 
 e8692ea4fdf924fb1ea06803d5e7321340754442 
   src/main/python/apache/aurora/client/base.py 
 cc08c18b1c4e664ca38efccca7f6d96a070479ba 
   src/main/python/apache/aurora/client/cli/context.py 
 fae30f6fc829699b6d775bce3fff1be3cde3dd65 
   src/main/python/apache/aurora/client/cli/jobs.py 
 c318926439dba2c99a4a34c153c8d3d0bef17207 
   src/main/python/apache/aurora/client/cli/task.py 
 1bd746da2f39f78b1497701f69777ca3ea6b70ea 
   src/main/python/apache/aurora/client/commands/admin.py 
 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 
   src/main/python/apache/aurora/client/commands/core.py 
 9b4c76a57eb7cb99a024febc5623606389fe7557 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 0568d91b4b13d8e3891eef2ce908d632e0402fa8 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  a9e5d89465a14c0d8bd4540b34e311763357f78f 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9fe47ae248473cccb42730c458d199219b1ffe7 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 09dda3bed6a5097f6dff8153249a7460a5b24d58 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3df042019d845421e5c8d79232ed865e342d44fc 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 854a98c9afe8e265a8794cbe6f9dc8af07181394 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 807994502a7f265bf4aae9b4af7ba77a2c3a9ace 
   src/test/python/apache/aurora/client/api/test_sla.py 
 02b36d5cd3322f6f03f1d6d525745faf2513f065 
   src/test/python/apache/aurora/client/api/test_updater.py 
 03a14186646daede689ac77e2ab7144aa5a7fa14 
   src/test/python/apache/aurora/client/cli/util.py 
 ccb6ea51eb636c2c564a0ee1a0ba2d41707bd2ca 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 bc3b92bdfc7838b6a0671078ef315ccd707eb5a5 
   src/test/python/apache/aurora/client/commands/util.py 
 4e587f320c785b56f5812364d50946cb2b6f03dc 
 
 Diff: https://reviews.apache.org/r/21830/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
  https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
 
  Would it make sense to change it to list instead? I can imagine how the 
  order may be helpful here in troubleshooting multi-message errors.

The use of set self-documents that you will not receive duplicate 
ResponseDetail objects.  Not sure i see the troubleshooting angle.


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java, line 44
  https://reviews.apache.org/r/21830/diff/2/?file=590893#file590893line44
 
  s/too/to

Fixed.


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java,
   line 49
  https://reviews.apache.org/r/21830/diff/2/?file=590896#file590896line49
 
  We don't inline @Inject with methods, why here?

I'm confused, i changed it to _not_ inline.  Am i misunderstanding?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---


On May 23, 2014, 7:30 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 23, 2014, 7:30 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  88bd20d55b488b30dba70d8c1469e058d1c761bc 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  2134609769d74755d11b43015bd1d17ad49132ec 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 ee22af10a469db1a3cc46d9092285977b5526f9e 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
   src/main/python/apache/aurora/client/api/__init__.py 
 f671ed860eee6ce57e4fee5e4ebbfb926fc2b3ae 
   src/main/python/apache/aurora/client/api/command_runner.py 
 c1459c4ba8553d82b9d9d1fdbf674f45006ca96c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 8992b93d25ce71b5784bad24429fd32356f64763 
   src/main/python/apache/aurora/client/api/quota_check.py 
 cfb56d7ae7e0f138c541b3125f27f010c0fe6c2a 
   src/main/python/apache/aurora/client/api/restarter.py 
 bceba63efd6e3ed198d3bdd041c8c961aa9c98c6 
   src/main/python/apache/aurora/client/api/updater.py 
 e8692ea4fdf924fb1ea06803d5e7321340754442 
   src/main/python/apache/aurora/client/base.py 
 cc08c18b1c4e664ca38efccca7f6d96a070479ba 
   src/main/python/apache/aurora/client/cli/context.py 
 fae30f6fc829699b6d775bce3fff1be3cde3dd65 
   src/main/python/apache/aurora/client/cli/jobs.py 
 c318926439dba2c99a4a34c153c8d3d0bef17207 
   src/main/python/apache/aurora/client/cli/task.py 
 1bd746da2f39f78b1497701f69777ca3ea6b70ea 
   src/main/python/apache/aurora/client/commands/admin.py 
 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 
   src/main/python/apache/aurora/client/commands/core.py 
 9b4c76a57eb7cb99a024febc5623606389fe7557 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 0568d91b4b13d8e3891eef2ce908d632e0402fa8 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  a9e5d89465a14c0d8bd4540b34e311763357f78f 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9fe47ae248473cccb42730c458d199219b1ffe7 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 09dda3bed6a5097f6dff8153249a7460a5b24d58 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3df042019d845421e5c8d79232ed865e342d44fc 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 854a98c9afe8e265a8794cbe6f9dc8af07181394 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 807994502a7f265bf4aae9b4af7ba77a2c3a9ace 
   src/test/python/apache/aurora/client/api/test_sla.py 
 02b36d5cd3322f6f03f1d6d525745faf2513f065 
   src/test/python/apache/aurora/client/api/test_updater.py 
 03a14186646daede689ac77e2ab7144aa5a7fa14 
   src/test/python/apache/aurora/client/cli/util.py 
 

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/
---

(Updated May 27, 2014, 5:39 p.m.)


Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
Khutornenko.


Changes
---

s/too/to/ + Rebase


Bugs: AURORA-461
https://issues.apache.org/jira/browse/AURORA-461


Repository: aurora


Description
---

This also included a small amount of cleanup in the aop package, since we now 
use a uniform response type.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
6f3ebd3191c766f28a6824d4c12c500a7aecf576 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
 8eb52dd87a79d9c17426197a5460e2a49d988e13 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
1d69aa108795d41844454dc79e809d18ff6904bc 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
8299cf308cb8bd318ccd441e5f1b5607b2df881f 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
 a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
  src/main/python/apache/aurora/client/api/__init__.py 
7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
  src/main/python/apache/aurora/client/api/command_runner.py 
b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
  src/main/python/apache/aurora/client/api/quota_check.py 
3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
  src/main/python/apache/aurora/client/api/restarter.py 
15258c4a6879c923b53d228af006b8cf6c6423a7 
  src/main/python/apache/aurora/client/api/updater.py 
f028498840ee4ed40790360ea6b6024ae623d60a 
  src/main/python/apache/aurora/client/base.py 
1f41ef05fafe5f5d73969d1453afd0dda0121927 
  src/main/python/apache/aurora/client/cli/context.py 
b1e8e407f27d6ae0512057211b147836f28eeac3 
  src/main/python/apache/aurora/client/cli/jobs.py 
59e3a37e65b1c715e37e55f053d60670598e3a1e 
  src/main/python/apache/aurora/client/cli/task.py 
d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
  src/main/python/apache/aurora/client/commands/admin.py 
4bf5735f1364ea1bed5387aabd08a845fa2390ee 
  src/main/python/apache/aurora/client/commands/core.py 
4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
89f1d90a93f1a339b7d8d27a86421726391d02f4 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
7fe1a00b229f17300731e5b7eb6fb976f9710661 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
9439d99361ab1800aec0c85b158ec1316172212c 
  src/test/python/apache/aurora/client/api/test_restarter.py 
0e00f448c45c9f575f126dbc0f1227893d7a79cf 
  src/test/python/apache/aurora/client/api/test_sla.py 
f9490b4dcc2ec051d68720e79afebfde982a79c5 
  src/test/python/apache/aurora/client/api/test_updater.py 
6be419eccc7e20c7728d6e52955db3fd289f6a29 
  src/test/python/apache/aurora/client/cli/util.py 
6533fae95b01c4ab3daf791fddf5417167bbbecb 
  src/test/python/apache/aurora/client/commands/test_kill.py 
00c4ceffd0ff562088a2215cc97d67a434e2394d 
  src/test/python/apache/aurora/client/commands/util.py 
f5346841f760f30143317ac49f1d0e54144b0419 

Diff: https://reviews.apache.org/r/21830/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Bill Farner



Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Mark Chu-Carroll


 On May 27, 2014, 12:36 p.m., Maxim Khutornenko wrote:
  src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
  https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
 
  Would it make sense to change it to list instead? I can imagine how the 
  order may be helpful here in troubleshooting multi-message errors.
 
 Bill Farner wrote:
 The use of set self-documents that you will not receive duplicate 
 ResponseDetail objects.  Not sure i see the troubleshooting angle.

I agree with Maxim about this one.

The order in which messages were added to the response could be a valuable 
piece of information about what order events occurred in.

Even if there were duplicates, it seems like the fact that the scheduler 
inserted two copies of a given message could be very valuable when debugging. 
It does seem like it would be wrong, but it would be wrong in a way that 
provides a helpful clue about what the server is doing.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---


On May 27, 2014, 1:39 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 27, 2014, 1:39 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  6f3ebd3191c766f28a6824d4c12c500a7aecf576 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  8eb52dd87a79d9c17426197a5460e2a49d988e13 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 1d69aa108795d41844454dc79e809d18ff6904bc 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 8299cf308cb8bd318ccd441e5f1b5607b2df881f 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
   src/main/python/apache/aurora/client/api/__init__.py 
 7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
   src/main/python/apache/aurora/client/api/command_runner.py 
 b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
   src/main/python/apache/aurora/client/api/quota_check.py 
 3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
   src/main/python/apache/aurora/client/api/restarter.py 
 15258c4a6879c923b53d228af006b8cf6c6423a7 
   src/main/python/apache/aurora/client/api/updater.py 
 f028498840ee4ed40790360ea6b6024ae623d60a 
   src/main/python/apache/aurora/client/base.py 
 1f41ef05fafe5f5d73969d1453afd0dda0121927 
   src/main/python/apache/aurora/client/cli/context.py 
 b1e8e407f27d6ae0512057211b147836f28eeac3 
   src/main/python/apache/aurora/client/cli/jobs.py 
 59e3a37e65b1c715e37e55f053d60670598e3a1e 
   src/main/python/apache/aurora/client/cli/task.py 
 d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
   src/main/python/apache/aurora/client/commands/admin.py 
 4bf5735f1364ea1bed5387aabd08a845fa2390ee 
   src/main/python/apache/aurora/client/commands/core.py 
 4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 89f1d90a93f1a339b7d8d27a86421726391d02f4 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 7fe1a00b229f17300731e5b7eb6fb976f9710661 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 9439d99361ab1800aec0c85b158ec1316172212c 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 0e00f448c45c9f575f126dbc0f1227893d7a79cf 
   src/test/python/apache/aurora/client/api/test_sla.py 
 f9490b4dcc2ec051d68720e79afebfde982a79c5 
   src/test/python/apache/aurora/client/api/test_updater.py 
 6be419eccc7e20c7728d6e52955db3fd289f6a29 
   src/test/python/apache/aurora/client/cli/util.py 
 6533fae95b01c4ab3daf791fddf5417167bbbecb 
   

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Maxim Khutornenko


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java,
   line 49
  https://reviews.apache.org/r/21830/diff/2/?file=590896#file590896line49
 
  We don't inline @Inject with methods, why here?
 
 Bill Farner wrote:
 I'm confused, i changed it to _not_ inline.  Am i misunderstanding?

You're right. Confused diff sides.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---


On May 27, 2014, 5:39 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 27, 2014, 5:39 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  6f3ebd3191c766f28a6824d4c12c500a7aecf576 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  8eb52dd87a79d9c17426197a5460e2a49d988e13 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 1d69aa108795d41844454dc79e809d18ff6904bc 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 8299cf308cb8bd318ccd441e5f1b5607b2df881f 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
   src/main/python/apache/aurora/client/api/__init__.py 
 7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
   src/main/python/apache/aurora/client/api/command_runner.py 
 b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
   src/main/python/apache/aurora/client/api/quota_check.py 
 3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
   src/main/python/apache/aurora/client/api/restarter.py 
 15258c4a6879c923b53d228af006b8cf6c6423a7 
   src/main/python/apache/aurora/client/api/updater.py 
 f028498840ee4ed40790360ea6b6024ae623d60a 
   src/main/python/apache/aurora/client/base.py 
 1f41ef05fafe5f5d73969d1453afd0dda0121927 
   src/main/python/apache/aurora/client/cli/context.py 
 b1e8e407f27d6ae0512057211b147836f28eeac3 
   src/main/python/apache/aurora/client/cli/jobs.py 
 59e3a37e65b1c715e37e55f053d60670598e3a1e 
   src/main/python/apache/aurora/client/cli/task.py 
 d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
   src/main/python/apache/aurora/client/commands/admin.py 
 4bf5735f1364ea1bed5387aabd08a845fa2390ee 
   src/main/python/apache/aurora/client/commands/core.py 
 4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 89f1d90a93f1a339b7d8d27a86421726391d02f4 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 7fe1a00b229f17300731e5b7eb6fb976f9710661 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 9439d99361ab1800aec0c85b158ec1316172212c 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 0e00f448c45c9f575f126dbc0f1227893d7a79cf 
   src/test/python/apache/aurora/client/api/test_sla.py 
 f9490b4dcc2ec051d68720e79afebfde982a79c5 
   src/test/python/apache/aurora/client/api/test_updater.py 
 6be419eccc7e20c7728d6e52955db3fd289f6a29 
   src/test/python/apache/aurora/client/cli/util.py 
 6533fae95b01c4ab3daf791fddf5417167bbbecb 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 00c4ceffd0ff562088a2215cc97d67a434e2394d 
   src/test/python/apache/aurora/client/commands/util.py 
 f5346841f760f30143317ac49f1d0e54144b0419 
 
 Diff: https://reviews.apache.org/r/21830/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
  https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
 
  Would it make sense to change it to list instead? I can imagine how the 
  order may be helpful here in troubleshooting multi-message errors.
 
 Bill Farner wrote:
 The use of set self-documents that you will not receive duplicate 
 ResponseDetail objects.  Not sure i see the troubleshooting angle.
 
 Mark Chu-Carroll wrote:
 I agree with Maxim about this one.
 
 The order in which messages were added to the response could be a 
 valuable piece of information about what order events occurred in.
 
 Even if there were duplicates, it seems like the fact that the scheduler 
 inserted two copies of a given message could be very valuable when debugging. 
 It does seem like it would be wrong, but it would be wrong in a way that 
 provides a helpful clue about what the server is doing.


I'm willing to give in on this, but isn't this an odd API?  It seems wrong to 
design the API to make it easier to diagnose bugs on the server.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---


On May 27, 2014, 5:39 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 27, 2014, 5:39 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  6f3ebd3191c766f28a6824d4c12c500a7aecf576 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  8eb52dd87a79d9c17426197a5460e2a49d988e13 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 1d69aa108795d41844454dc79e809d18ff6904bc 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 8299cf308cb8bd318ccd441e5f1b5607b2df881f 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
   src/main/python/apache/aurora/client/api/__init__.py 
 7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
   src/main/python/apache/aurora/client/api/command_runner.py 
 b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
   src/main/python/apache/aurora/client/api/quota_check.py 
 3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
   src/main/python/apache/aurora/client/api/restarter.py 
 15258c4a6879c923b53d228af006b8cf6c6423a7 
   src/main/python/apache/aurora/client/api/updater.py 
 f028498840ee4ed40790360ea6b6024ae623d60a 
   src/main/python/apache/aurora/client/base.py 
 1f41ef05fafe5f5d73969d1453afd0dda0121927 
   src/main/python/apache/aurora/client/cli/context.py 
 b1e8e407f27d6ae0512057211b147836f28eeac3 
   src/main/python/apache/aurora/client/cli/jobs.py 
 59e3a37e65b1c715e37e55f053d60670598e3a1e 
   src/main/python/apache/aurora/client/cli/task.py 
 d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
   src/main/python/apache/aurora/client/commands/admin.py 
 4bf5735f1364ea1bed5387aabd08a845fa2390ee 
   src/main/python/apache/aurora/client/commands/core.py 
 4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 89f1d90a93f1a339b7d8d27a86421726391d02f4 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 7fe1a00b229f17300731e5b7eb6fb976f9710661 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 9439d99361ab1800aec0c85b158ec1316172212c 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 0e00f448c45c9f575f126dbc0f1227893d7a79cf 
   src/test/python/apache/aurora/client/api/test_sla.py 
 f9490b4dcc2ec051d68720e79afebfde982a79c5 
   

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Maxim Khutornenko


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
  https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
 
  Would it make sense to change it to list instead? I can imagine how the 
  order may be helpful here in troubleshooting multi-message errors.
 
 Bill Farner wrote:
 The use of set self-documents that you will not receive duplicate 
 ResponseDetail objects.  Not sure i see the troubleshooting angle.
 
 Mark Chu-Carroll wrote:
 I agree with Maxim about this one.
 
 The order in which messages were added to the response could be a 
 valuable piece of information about what order events occurred in.
 
 Even if there were duplicates, it seems like the fact that the scheduler 
 inserted two copies of a given message could be very valuable when debugging. 
 It does seem like it would be wrong, but it would be wrong in a way that 
 provides a helpful clue about what the server is doing.

 
 Bill Farner wrote:
 I'm willing to give in on this, but isn't this an odd API?  It seems 
 wrong to design the API to make it easier to diagnose bugs on the server.

I don't think it's only server bugs where it could be helpful. Preserving an 
order may help consuming messages where context matters. Couple possible 
examples: config validation checks or hierarchy/sequence navigation (e.g.: 
reporting lock violations for cluster/role/env/job hierarchy). 


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---


On May 27, 2014, 5:39 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 27, 2014, 5:39 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  6f3ebd3191c766f28a6824d4c12c500a7aecf576 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  8eb52dd87a79d9c17426197a5460e2a49d988e13 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 1d69aa108795d41844454dc79e809d18ff6904bc 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 8299cf308cb8bd318ccd441e5f1b5607b2df881f 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
   src/main/python/apache/aurora/client/api/__init__.py 
 7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
   src/main/python/apache/aurora/client/api/command_runner.py 
 b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
   src/main/python/apache/aurora/client/api/quota_check.py 
 3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
   src/main/python/apache/aurora/client/api/restarter.py 
 15258c4a6879c923b53d228af006b8cf6c6423a7 
   src/main/python/apache/aurora/client/api/updater.py 
 f028498840ee4ed40790360ea6b6024ae623d60a 
   src/main/python/apache/aurora/client/base.py 
 1f41ef05fafe5f5d73969d1453afd0dda0121927 
   src/main/python/apache/aurora/client/cli/context.py 
 b1e8e407f27d6ae0512057211b147836f28eeac3 
   src/main/python/apache/aurora/client/cli/jobs.py 
 59e3a37e65b1c715e37e55f053d60670598e3a1e 
   src/main/python/apache/aurora/client/cli/task.py 
 d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
   src/main/python/apache/aurora/client/commands/admin.py 
 4bf5735f1364ea1bed5387aabd08a845fa2390ee 
   src/main/python/apache/aurora/client/commands/core.py 
 4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 89f1d90a93f1a339b7d8d27a86421726391d02f4 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 7fe1a00b229f17300731e5b7eb6fb976f9710661 
   

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner


 On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
  src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
  https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
 
  Would it make sense to change it to list instead? I can imagine how the 
  order may be helpful here in troubleshooting multi-message errors.
 
 Bill Farner wrote:
 The use of set self-documents that you will not receive duplicate 
 ResponseDetail objects.  Not sure i see the troubleshooting angle.
 
 Mark Chu-Carroll wrote:
 I agree with Maxim about this one.
 
 The order in which messages were added to the response could be a 
 valuable piece of information about what order events occurred in.
 
 Even if there were duplicates, it seems like the fact that the scheduler 
 inserted two copies of a given message could be very valuable when debugging. 
 It does seem like it would be wrong, but it would be wrong in a way that 
 provides a helpful clue about what the server is doing.

 
 Bill Farner wrote:
 I'm willing to give in on this, but isn't this an odd API?  It seems 
 wrong to design the API to make it easier to diagnose bugs on the server.
 
 Maxim Khutornenko wrote:
 I don't think it's only server bugs where it could be helpful. Preserving 
 an order may help consuming messages where context matters. Couple possible 
 examples: config validation checks or hierarchy/sequence navigation (e.g.: 
 reporting lock violations for cluster/role/env/job hierarchy).

Ok, i'll cave.  Latest diff switches to List.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43977
---


On May 27, 2014, 5:39 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 27, 2014, 5:39 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  6f3ebd3191c766f28a6824d4c12c500a7aecf576 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  8eb52dd87a79d9c17426197a5460e2a49d988e13 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 1d69aa108795d41844454dc79e809d18ff6904bc 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 8299cf308cb8bd318ccd441e5f1b5607b2df881f 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
   src/main/python/apache/aurora/client/api/__init__.py 
 7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
   src/main/python/apache/aurora/client/api/command_runner.py 
 b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
   src/main/python/apache/aurora/client/api/quota_check.py 
 3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
   src/main/python/apache/aurora/client/api/restarter.py 
 15258c4a6879c923b53d228af006b8cf6c6423a7 
   src/main/python/apache/aurora/client/api/updater.py 
 f028498840ee4ed40790360ea6b6024ae623d60a 
   src/main/python/apache/aurora/client/base.py 
 1f41ef05fafe5f5d73969d1453afd0dda0121927 
   src/main/python/apache/aurora/client/cli/context.py 
 b1e8e407f27d6ae0512057211b147836f28eeac3 
   src/main/python/apache/aurora/client/cli/jobs.py 
 59e3a37e65b1c715e37e55f053d60670598e3a1e 
   src/main/python/apache/aurora/client/cli/task.py 
 d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
   src/main/python/apache/aurora/client/commands/admin.py 
 4bf5735f1364ea1bed5387aabd08a845fa2390ee 
   src/main/python/apache/aurora/client/commands/core.py 
 4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 89f1d90a93f1a339b7d8d27a86421726391d02f4 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-27 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/
---

(Updated May 27, 2014, 11 p.m.)


Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
Khutornenko.


Changes
---

Rebased, fixed a few PMD warnings.


Bugs: AURORA-461
https://issues.apache.org/jira/browse/AURORA-461


Repository: aurora


Description
---

This also included a small amount of cleanup in the aop package, since we now 
use a uniform response type.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
29f64f7b95db146355c532620ade55c7c097e518 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
 0c1477ca5316ff219d2a22d7e5fea599c56999a4 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
1d69aa108795d41844454dc79e809d18ff6904bc 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
8299cf308cb8bd318ccd441e5f1b5607b2df881f 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
 a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 
  src/main/python/apache/aurora/client/api/__init__.py 
7c15d9dbd4fa9fa149cff867a31f0ce092beef95 
  src/main/python/apache/aurora/client/api/command_runner.py 
b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 
  src/main/python/apache/aurora/client/api/quota_check.py 
3a73f2406c4bfa94bd75ea02490b7c6a946f379b 
  src/main/python/apache/aurora/client/api/restarter.py 
15258c4a6879c923b53d228af006b8cf6c6423a7 
  src/main/python/apache/aurora/client/api/updater.py 
f028498840ee4ed40790360ea6b6024ae623d60a 
  src/main/python/apache/aurora/client/base.py 
1f41ef05fafe5f5d73969d1453afd0dda0121927 
  src/main/python/apache/aurora/client/cli/context.py 
b1e8e407f27d6ae0512057211b147836f28eeac3 
  src/main/python/apache/aurora/client/cli/jobs.py 
59e3a37e65b1c715e37e55f053d60670598e3a1e 
  src/main/python/apache/aurora/client/cli/task.py 
d5c58db0375c0a59f3ee1f1b682813e34da44aa0 
  src/main/python/apache/aurora/client/commands/admin.py 
4bf5735f1364ea1bed5387aabd08a845fa2390ee 
  src/main/python/apache/aurora/client/commands/core.py 
4eb4e465dcdea859984835dfa9878b1d92ccb5ab 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 75bb01b25f47cb46f229dd08a4c0881191aa5fe4 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
08d671b0591069ed0db87fb7ee64c8d81e5b0e8c 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
89f1d90a93f1a339b7d8d27a86421726391d02f4 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
7fe1a00b229f17300731e5b7eb6fb976f9710661 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
9439d99361ab1800aec0c85b158ec1316172212c 
  src/test/python/apache/aurora/client/api/test_restarter.py 
0e00f448c45c9f575f126dbc0f1227893d7a79cf 
  src/test/python/apache/aurora/client/api/test_sla.py 
f9490b4dcc2ec051d68720e79afebfde982a79c5 
  src/test/python/apache/aurora/client/api/test_updater.py 
6be419eccc7e20c7728d6e52955db3fd289f6a29 
  src/test/python/apache/aurora/client/cli/util.py 
6533fae95b01c4ab3daf791fddf5417167bbbecb 
  src/test/python/apache/aurora/client/commands/test_kill.py 
00c4ceffd0ff562088a2215cc97d67a434e2394d 
  src/test/python/apache/aurora/client/commands/util.py 
f5346841f760f30143317ac49f1d0e54144b0419 

Diff: https://reviews.apache.org/r/21830/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Bill Farner



Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/
---

(Updated May 23, 2014, 7:30 p.m.)


Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
Khutornenko.


Changes
---

Fixed python changes lacking in previous diff.  Passes 
./build-support/jenkins/build.sh


Bugs: AURORA-461
https://issues.apache.org/jira/browse/AURORA-461


Repository: aurora


Description
---

This also included a small amount of cleanup in the aop package, since we now 
use a uniform response type.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
88bd20d55b488b30dba70d8c1469e058d1c761bc 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
 2134609769d74755d11b43015bd1d17ad49132ec 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
ee22af10a469db1a3cc46d9092285977b5526f9e 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
 801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
  src/main/python/apache/aurora/client/api/__init__.py 
f671ed860eee6ce57e4fee5e4ebbfb926fc2b3ae 
  src/main/python/apache/aurora/client/api/command_runner.py 
c1459c4ba8553d82b9d9d1fdbf674f45006ca96c 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
8992b93d25ce71b5784bad24429fd32356f64763 
  src/main/python/apache/aurora/client/api/quota_check.py 
cfb56d7ae7e0f138c541b3125f27f010c0fe6c2a 
  src/main/python/apache/aurora/client/api/restarter.py 
bceba63efd6e3ed198d3bdd041c8c961aa9c98c6 
  src/main/python/apache/aurora/client/api/updater.py 
e8692ea4fdf924fb1ea06803d5e7321340754442 
  src/main/python/apache/aurora/client/base.py 
cc08c18b1c4e664ca38efccca7f6d96a070479ba 
  src/main/python/apache/aurora/client/cli/context.py 
fae30f6fc829699b6d775bce3fff1be3cde3dd65 
  src/main/python/apache/aurora/client/cli/jobs.py 
c318926439dba2c99a4a34c153c8d3d0bef17207 
  src/main/python/apache/aurora/client/cli/task.py 
1bd746da2f39f78b1497701f69777ca3ea6b70ea 
  src/main/python/apache/aurora/client/commands/admin.py 
16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 
  src/main/python/apache/aurora/client/commands/core.py 
9b4c76a57eb7cb99a024febc5623606389fe7557 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
0568d91b4b13d8e3891eef2ce908d632e0402fa8 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 a9e5d89465a14c0d8bd4540b34e311763357f78f 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
e9fe47ae248473cccb42730c458d199219b1ffe7 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
09dda3bed6a5097f6dff8153249a7460a5b24d58 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
3df042019d845421e5c8d79232ed865e342d44fc 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
854a98c9afe8e265a8794cbe6f9dc8af07181394 
  src/test/python/apache/aurora/client/api/test_restarter.py 
807994502a7f265bf4aae9b4af7ba77a2c3a9ace 
  src/test/python/apache/aurora/client/api/test_sla.py 
02b36d5cd3322f6f03f1d6d525745faf2513f065 
  src/test/python/apache/aurora/client/api/test_updater.py 
03a14186646daede689ac77e2ab7144aa5a7fa14 
  src/test/python/apache/aurora/client/cli/util.py 
ccb6ea51eb636c2c564a0ee1a0ba2d41707bd2ca 
  src/test/python/apache/aurora/client/commands/test_kill.py 
bc3b92bdfc7838b6a0671078ef315ccd707eb5a5 
  src/test/python/apache/aurora/client/commands/util.py 
4e587f320c785b56f5812364d50946cb2b6f03dc 

Diff: https://reviews.apache.org/r/21830/diff/


Testing (updated)
---

./build-support/jenkins/build.sh


Thanks,

Bill Farner



Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43868
---


Also passes old and new end-to-end tests.

- Bill Farner


On May 23, 2014, 7:30 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 23, 2014, 7:30 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  88bd20d55b488b30dba70d8c1469e058d1c761bc 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  2134609769d74755d11b43015bd1d17ad49132ec 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 ee22af10a469db1a3cc46d9092285977b5526f9e 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
   src/main/python/apache/aurora/client/api/__init__.py 
 f671ed860eee6ce57e4fee5e4ebbfb926fc2b3ae 
   src/main/python/apache/aurora/client/api/command_runner.py 
 c1459c4ba8553d82b9d9d1fdbf674f45006ca96c 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 8992b93d25ce71b5784bad24429fd32356f64763 
   src/main/python/apache/aurora/client/api/quota_check.py 
 cfb56d7ae7e0f138c541b3125f27f010c0fe6c2a 
   src/main/python/apache/aurora/client/api/restarter.py 
 bceba63efd6e3ed198d3bdd041c8c961aa9c98c6 
   src/main/python/apache/aurora/client/api/updater.py 
 e8692ea4fdf924fb1ea06803d5e7321340754442 
   src/main/python/apache/aurora/client/base.py 
 cc08c18b1c4e664ca38efccca7f6d96a070479ba 
   src/main/python/apache/aurora/client/cli/context.py 
 fae30f6fc829699b6d775bce3fff1be3cde3dd65 
   src/main/python/apache/aurora/client/cli/jobs.py 
 c318926439dba2c99a4a34c153c8d3d0bef17207 
   src/main/python/apache/aurora/client/cli/task.py 
 1bd746da2f39f78b1497701f69777ca3ea6b70ea 
   src/main/python/apache/aurora/client/commands/admin.py 
 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 
   src/main/python/apache/aurora/client/commands/core.py 
 9b4c76a57eb7cb99a024febc5623606389fe7557 
   src/main/python/apache/aurora/client/hooks/hooked_api.py 
 0568d91b4b13d8e3891eef2ce908d632e0402fa8 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  a9e5d89465a14c0d8bd4540b34e311763357f78f 
   src/test/python/apache/aurora/client/api/test_disambiguator.py 
 e9fe47ae248473cccb42730c458d199219b1ffe7 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 09dda3bed6a5097f6dff8153249a7460a5b24d58 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3df042019d845421e5c8d79232ed865e342d44fc 
   src/test/python/apache/aurora/client/api/test_quota_check.py 
 854a98c9afe8e265a8794cbe6f9dc8af07181394 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 807994502a7f265bf4aae9b4af7ba77a2c3a9ace 
   src/test/python/apache/aurora/client/api/test_sla.py 
 02b36d5cd3322f6f03f1d6d525745faf2513f065 
   src/test/python/apache/aurora/client/api/test_updater.py 
 03a14186646daede689ac77e2ab7144aa5a7fa14 
   src/test/python/apache/aurora/client/cli/util.py 
 ccb6ea51eb636c2c564a0ee1a0ba2d41707bd2ca 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 bc3b92bdfc7838b6a0671078ef315ccd707eb5a5 
   src/test/python/apache/aurora/client/commands/util.py 
 4e587f320c785b56f5812364d50946cb2b6f03dc 
 
 Diff: https://reviews.apache.org/r/21830/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43796
---


This will not pass python tests as we reference resp.message in quite a few 
places.

- Maxim Khutornenko


On May 22, 2014, 9:58 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 22, 2014, 9:58 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  88bd20d55b488b30dba70d8c1469e058d1c761bc 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  2134609769d74755d11b43015bd1d17ad49132ec 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 ee22af10a469db1a3cc46d9092285977b5526f9e 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  a9e5d89465a14c0d8bd4540b34e311763357f78f 
 
 Diff: https://reviews.apache.org/r/21830/diff/
 
 
 Testing
 ---
 
 ./gradlew build
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43801
---

Ship it!


Looks great; thanks for doing this so quickly!

- Mark Chu-Carroll


On May 22, 2014, 5:58 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21830/
 ---
 
 (Updated May 22, 2014, 5:58 p.m.)
 
 
 Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim 
 Khutornenko.
 
 
 Bugs: AURORA-461
 https://issues.apache.org/jira/browse/AURORA-461
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This also included a small amount of cleanup in the aop package, since we now 
 use a uniform response type.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  88bd20d55b488b30dba70d8c1469e058d1c761bc 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
  2134609769d74755d11b43015bd1d17ad49132ec 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java 
 ee22af10a469db1a3cc46d9092285977b5526f9e 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
 5f8143c146a25196d6ecc10d93c8e8e99d4e06be 
   
 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
  801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  a9e5d89465a14c0d8bd4540b34e311763357f78f 
 
 Diff: https://reviews.apache.org/r/21830/diff/
 
 
 Testing
 ---
 
 ./gradlew build
 
 
 Thanks,
 
 Bill Farner