Re: Review Request 21884: Fixup empty line from license headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21884/#review43895 --- Ship it! +1 Thanks for the update patch, Bill. Need to sharpen my bash script-fu. - Henry Saputra On May 24, 2014, 7:11 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21884/ > --- > > (Updated May 24, 2014, 7:11 a.m.) > > > Review request for Aurora and Henry Saputra. > > > Repository: aurora > > > Description > --- > > Realized after the fact that a013703 left an empty line in headers. This > fixed them up. > > > Diffs > - > > 3rdparty/javascript/thrift.js 41405a21b7119828384ceb92dfca085091a4f265 > 3rdparty/python/BUILD 6011ec1d8d4240196867035e4024b25a2978ec26 > BUILD cf1d5b65e7083629f396066cdcf7dc0e28ea1775 > LICENSE 71b778a369a1b10c8d006fab2b9dc5b556198a04 > Vagrantfile 57b9613216f549fc7052aaab7b458bf5af07d8d7 > build-support/hooks/pre-commit 01be0e9ab03bd0496e4dd02a8554125bf47dc426 > build-support/isort 656248284115c2de389f8d434883cc18e1eba5c1 > build-support/isort-check 1d90bc0882f2a13e5644a11b9245b827c44df751 > build-support/isort-run a4725e2ee22f8ae9934651c7cb5502833103dbfd > build-support/jenkins/build.sh 2895470b5f578dab19b2851355af3e7f8b727b41 > build-support/pex 77c99e1c71090f404da3fdd5f0ec3893e1a6d7ed > build-support/release/changelog a92aee2e2126ea5b764ed92af41a0bb4ae9c9d0c > build-support/release/make-python-sdists > e51f937bf74eb6c4c09608f83ee7dc52f9ddff76 > build-support/release/release 08372cec7faffaa1e37f940b1040d61fad35edb0 > build-support/release/release-candidate > 4443e48d74f9cefa84b1bf8263266c286c58d6e8 > build-support/release/verify-release-candidate > 906657f249f576a7182f90e54cbd675d81e7ab3f > build-support/thrift/Makefile 8d7099c1f9d1545b44277ae3b5b2338e239d8e12 > build-support/tools/list-missing-shipits > 596dd0abe2d118cb8734e207baa21b09ca060518 > build-support/virtualenv 00ef972c050646a7406fd4a78beeafa90e6f0dc6 > build.gradle 2a2761d73ee7ed2f501b8ca2238a5bf6e038596b > config/checkstyle/apache.header.regex > 1bfe993a45fb25043d1475352f6c860629ac50d7 > examples/scheduler/scheduler-local.sh > a80ccaec49c2194f9709409a494523e907acd8a6 > examples/vagrant/provision-dev-cluster.sh > 69b0d857247e5c57b5dd9df2eb00021d9c65029a > examples/vagrant/test_tutorial.sh b713e39401dee67fb4e7f4bfeabc3c460ef31031 > examples/vagrant/upstart/aurora-scheduler.conf > f5a2687f4ff1506f4f8eb53c49bf0d4ef8a30dbc > examples/vagrant/upstart/aurora-thermos-observer.conf > be8d99e9159aae28e4c3b74857fc210e2ac1f6fc > examples/vagrant/upstart/mesos-master.conf > f3e98d2ed329d0a30f11fd52fe436d9e3172a740 > examples/vagrant/upstart/mesos-slave.conf > 59db0408624ccd15ef0408e6b16e511cf7bce72f > examples/vagrant/upstart/zookeeper.conf > ebdf29b43d58896be56563fb284a8cb8ce457057 > gradlew da10ba6e08e30cb3cb0a45e2edef03e8143b55aa > pants 6873ecc15ed072c6c60a199900d84f12dfc4c6a4 > pants.ini b9b1db9b10684842f6038206fb932696dab0fedd > rbt 41c91c9edcdd6d71581f4eb0b9cae66bd00cb8e4 > src/main/java/org/apache/aurora/GuiceUtils.java > 4e873381d61f4d533553c2139a59ccc9807eb3c2 > src/main/java/org/apache/aurora/Protobufs.java > c4527c725a47522e559eab540ecfa148a40fe36e > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 54099aea97adf0a82c049685d7945d43f8fe50e4 > src/main/java/org/apache/aurora/auth/SessionValidator.java > ac9d2f5ae3ca381927c987044aabc1dd1d9ecaa9 > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java > 03fdbc3b4c262412d916eb050de9e97daf1db9fd > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 468151762344ce307dd3ec5e29f65fe3afe2a319 > src/main/java/org/apache/aurora/scheduler/Driver.java > e88481b7842c018a8507461dfbb7e1b929a0e999 > src/main/java/org/apache/aurora/scheduler/DriverFactory.java > 20ee2a83ddbc47426c011ed35d79514d05edf64e > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java > 2a67cd7f3458db9250b54b38cb6145e3aa9b164a > src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java > ae751dcde4f39015f80991846e0814540582d325 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > a93f8a4834feb926c07ca4cb1a3d8fa25f755d53 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > dbe0a715680bbe3bd908efab7b630ba21ca50f2d > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 4e3ae2968a23bfe2e23d88744ad5fb8542b558ea > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > bc87e544b6d72e921287dc032d77a1c8ca143428 > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java > c70bf74dfeb55e070c1ede7fb0d5bf7a26c20b33 >
Re: Review Request 21884: Fixup empty line from license headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21884/#review43894 --- Ship it! +1 Thanks for the update patch, Bill. Need to sharpen my bash script-fu. - Henry Saputra On May 24, 2014, 7:11 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21884/ > --- > > (Updated May 24, 2014, 7:11 a.m.) > > > Review request for Aurora and Henry Saputra. > > > Repository: aurora > > > Description > --- > > Realized after the fact that a013703 left an empty line in headers. This > fixed them up. > > > Diffs > - > > 3rdparty/javascript/thrift.js 41405a21b7119828384ceb92dfca085091a4f265 > 3rdparty/python/BUILD 6011ec1d8d4240196867035e4024b25a2978ec26 > BUILD cf1d5b65e7083629f396066cdcf7dc0e28ea1775 > LICENSE 71b778a369a1b10c8d006fab2b9dc5b556198a04 > Vagrantfile 57b9613216f549fc7052aaab7b458bf5af07d8d7 > build-support/hooks/pre-commit 01be0e9ab03bd0496e4dd02a8554125bf47dc426 > build-support/isort 656248284115c2de389f8d434883cc18e1eba5c1 > build-support/isort-check 1d90bc0882f2a13e5644a11b9245b827c44df751 > build-support/isort-run a4725e2ee22f8ae9934651c7cb5502833103dbfd > build-support/jenkins/build.sh 2895470b5f578dab19b2851355af3e7f8b727b41 > build-support/pex 77c99e1c71090f404da3fdd5f0ec3893e1a6d7ed > build-support/release/changelog a92aee2e2126ea5b764ed92af41a0bb4ae9c9d0c > build-support/release/make-python-sdists > e51f937bf74eb6c4c09608f83ee7dc52f9ddff76 > build-support/release/release 08372cec7faffaa1e37f940b1040d61fad35edb0 > build-support/release/release-candidate > 4443e48d74f9cefa84b1bf8263266c286c58d6e8 > build-support/release/verify-release-candidate > 906657f249f576a7182f90e54cbd675d81e7ab3f > build-support/thrift/Makefile 8d7099c1f9d1545b44277ae3b5b2338e239d8e12 > build-support/tools/list-missing-shipits > 596dd0abe2d118cb8734e207baa21b09ca060518 > build-support/virtualenv 00ef972c050646a7406fd4a78beeafa90e6f0dc6 > build.gradle 2a2761d73ee7ed2f501b8ca2238a5bf6e038596b > config/checkstyle/apache.header.regex > 1bfe993a45fb25043d1475352f6c860629ac50d7 > examples/scheduler/scheduler-local.sh > a80ccaec49c2194f9709409a494523e907acd8a6 > examples/vagrant/provision-dev-cluster.sh > 69b0d857247e5c57b5dd9df2eb00021d9c65029a > examples/vagrant/test_tutorial.sh b713e39401dee67fb4e7f4bfeabc3c460ef31031 > examples/vagrant/upstart/aurora-scheduler.conf > f5a2687f4ff1506f4f8eb53c49bf0d4ef8a30dbc > examples/vagrant/upstart/aurora-thermos-observer.conf > be8d99e9159aae28e4c3b74857fc210e2ac1f6fc > examples/vagrant/upstart/mesos-master.conf > f3e98d2ed329d0a30f11fd52fe436d9e3172a740 > examples/vagrant/upstart/mesos-slave.conf > 59db0408624ccd15ef0408e6b16e511cf7bce72f > examples/vagrant/upstart/zookeeper.conf > ebdf29b43d58896be56563fb284a8cb8ce457057 > gradlew da10ba6e08e30cb3cb0a45e2edef03e8143b55aa > pants 6873ecc15ed072c6c60a199900d84f12dfc4c6a4 > pants.ini b9b1db9b10684842f6038206fb932696dab0fedd > rbt 41c91c9edcdd6d71581f4eb0b9cae66bd00cb8e4 > src/main/java/org/apache/aurora/GuiceUtils.java > 4e873381d61f4d533553c2139a59ccc9807eb3c2 > src/main/java/org/apache/aurora/Protobufs.java > c4527c725a47522e559eab540ecfa148a40fe36e > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 54099aea97adf0a82c049685d7945d43f8fe50e4 > src/main/java/org/apache/aurora/auth/SessionValidator.java > ac9d2f5ae3ca381927c987044aabc1dd1d9ecaa9 > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java > 03fdbc3b4c262412d916eb050de9e97daf1db9fd > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 468151762344ce307dd3ec5e29f65fe3afe2a319 > src/main/java/org/apache/aurora/scheduler/Driver.java > e88481b7842c018a8507461dfbb7e1b929a0e999 > src/main/java/org/apache/aurora/scheduler/DriverFactory.java > 20ee2a83ddbc47426c011ed35d79514d05edf64e > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java > 2a67cd7f3458db9250b54b38cb6145e3aa9b164a > src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java > ae751dcde4f39015f80991846e0814540582d325 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > a93f8a4834feb926c07ca4cb1a3d8fa25f755d53 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > dbe0a715680bbe3bd908efab7b630ba21ca50f2d > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 4e3ae2968a23bfe2e23d88744ad5fb8542b558ea > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > bc87e544b6d72e921287dc032d77a1c8ca143428 > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java > c70bf74dfeb55e070c1ede7fb0d5bf7a26c20b33 >
Re: Review Request 21884: Fixup empty line from license headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21884/#review43893 --- Ship it! Ship It! - Henry Saputra On May 24, 2014, 7:11 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21884/ > --- > > (Updated May 24, 2014, 7:11 a.m.) > > > Review request for Aurora and Henry Saputra. > > > Repository: aurora > > > Description > --- > > Realized after the fact that a013703 left an empty line in headers. This > fixed them up. > > > Diffs > - > > 3rdparty/javascript/thrift.js 41405a21b7119828384ceb92dfca085091a4f265 > 3rdparty/python/BUILD 6011ec1d8d4240196867035e4024b25a2978ec26 > BUILD cf1d5b65e7083629f396066cdcf7dc0e28ea1775 > LICENSE 71b778a369a1b10c8d006fab2b9dc5b556198a04 > Vagrantfile 57b9613216f549fc7052aaab7b458bf5af07d8d7 > build-support/hooks/pre-commit 01be0e9ab03bd0496e4dd02a8554125bf47dc426 > build-support/isort 656248284115c2de389f8d434883cc18e1eba5c1 > build-support/isort-check 1d90bc0882f2a13e5644a11b9245b827c44df751 > build-support/isort-run a4725e2ee22f8ae9934651c7cb5502833103dbfd > build-support/jenkins/build.sh 2895470b5f578dab19b2851355af3e7f8b727b41 > build-support/pex 77c99e1c71090f404da3fdd5f0ec3893e1a6d7ed > build-support/release/changelog a92aee2e2126ea5b764ed92af41a0bb4ae9c9d0c > build-support/release/make-python-sdists > e51f937bf74eb6c4c09608f83ee7dc52f9ddff76 > build-support/release/release 08372cec7faffaa1e37f940b1040d61fad35edb0 > build-support/release/release-candidate > 4443e48d74f9cefa84b1bf8263266c286c58d6e8 > build-support/release/verify-release-candidate > 906657f249f576a7182f90e54cbd675d81e7ab3f > build-support/thrift/Makefile 8d7099c1f9d1545b44277ae3b5b2338e239d8e12 > build-support/tools/list-missing-shipits > 596dd0abe2d118cb8734e207baa21b09ca060518 > build-support/virtualenv 00ef972c050646a7406fd4a78beeafa90e6f0dc6 > build.gradle 2a2761d73ee7ed2f501b8ca2238a5bf6e038596b > config/checkstyle/apache.header.regex > 1bfe993a45fb25043d1475352f6c860629ac50d7 > examples/scheduler/scheduler-local.sh > a80ccaec49c2194f9709409a494523e907acd8a6 > examples/vagrant/provision-dev-cluster.sh > 69b0d857247e5c57b5dd9df2eb00021d9c65029a > examples/vagrant/test_tutorial.sh b713e39401dee67fb4e7f4bfeabc3c460ef31031 > examples/vagrant/upstart/aurora-scheduler.conf > f5a2687f4ff1506f4f8eb53c49bf0d4ef8a30dbc > examples/vagrant/upstart/aurora-thermos-observer.conf > be8d99e9159aae28e4c3b74857fc210e2ac1f6fc > examples/vagrant/upstart/mesos-master.conf > f3e98d2ed329d0a30f11fd52fe436d9e3172a740 > examples/vagrant/upstart/mesos-slave.conf > 59db0408624ccd15ef0408e6b16e511cf7bce72f > examples/vagrant/upstart/zookeeper.conf > ebdf29b43d58896be56563fb284a8cb8ce457057 > gradlew da10ba6e08e30cb3cb0a45e2edef03e8143b55aa > pants 6873ecc15ed072c6c60a199900d84f12dfc4c6a4 > pants.ini b9b1db9b10684842f6038206fb932696dab0fedd > rbt 41c91c9edcdd6d71581f4eb0b9cae66bd00cb8e4 > src/main/java/org/apache/aurora/GuiceUtils.java > 4e873381d61f4d533553c2139a59ccc9807eb3c2 > src/main/java/org/apache/aurora/Protobufs.java > c4527c725a47522e559eab540ecfa148a40fe36e > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 54099aea97adf0a82c049685d7945d43f8fe50e4 > src/main/java/org/apache/aurora/auth/SessionValidator.java > ac9d2f5ae3ca381927c987044aabc1dd1d9ecaa9 > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java > 03fdbc3b4c262412d916eb050de9e97daf1db9fd > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 468151762344ce307dd3ec5e29f65fe3afe2a319 > src/main/java/org/apache/aurora/scheduler/Driver.java > e88481b7842c018a8507461dfbb7e1b929a0e999 > src/main/java/org/apache/aurora/scheduler/DriverFactory.java > 20ee2a83ddbc47426c011ed35d79514d05edf64e > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java > 2a67cd7f3458db9250b54b38cb6145e3aa9b164a > src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java > ae751dcde4f39015f80991846e0814540582d325 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > a93f8a4834feb926c07ca4cb1a3d8fa25f755d53 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > dbe0a715680bbe3bd908efab7b630ba21ca50f2d > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 4e3ae2968a23bfe2e23d88744ad5fb8542b558ea > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > bc87e544b6d72e921287dc032d77a1c8ca143428 > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java > c70bf74dfeb55e070c1ede7fb0d5bf7a26c20b33 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 379ef
