Re: Review Request 22408: Log SlaveID without newline.

2014-06-16 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22408/#review45813
---

Ship it!


Ship It!

- Maxim Khutornenko


On June 10, 2014, 1:45 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22408/
> ---
> 
> (Updated June 10, 2014, 1:45 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log SlaveID without newline.
> 
> Before:
> 
> I0610 00:01:07.042 THREAD126 
> org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
> on slave slave.example.com (id value: 
> "20140519-221756-1772369162-5050-63135-219"
> ) is being assigned task for 
> 1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.
> 
> After:
> 
> I0610 00:01:07.042 THREAD126 
> org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
> on slave slave.example.com (20140519-221756-1772369162-5050-63135-219) is 
> being assigned task for 
> 1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 8e14a76a80e62f2784089ea922e3ad9a2035a7f8 
> 
> Diff: https://reviews.apache.org/r/22408/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L54-L62
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Re: Review Request 22408: Log SlaveID without newline.

2014-06-16 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22408/#review45805
---

Ship it!


Ship It!

- Brian Wickman


On June 10, 2014, 1:45 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22408/
> ---
> 
> (Updated June 10, 2014, 1:45 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log SlaveID without newline.
> 
> Before:
> 
> I0610 00:01:07.042 THREAD126 
> org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
> on slave slave.example.com (id value: 
> "20140519-221756-1772369162-5050-63135-219"
> ) is being assigned task for 
> 1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.
> 
> After:
> 
> I0610 00:01:07.042 THREAD126 
> org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
> on slave slave.example.com (20140519-221756-1772369162-5050-63135-219) is 
> being assigned task for 
> 1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 8e14a76a80e62f2784089ea922e3ad9a2035a7f8 
> 
> Diff: https://reviews.apache.org/r/22408/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L54-L62
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Re: Review Request 22408: Log SlaveID without newline.

2014-06-10 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22408/#review45275
---

Ship it!


Ship It!

- Joe Smith


On June 9, 2014, 6:45 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22408/
> ---
> 
> (Updated June 9, 2014, 6:45 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Log SlaveID without newline.
> 
> Before:
> 
> I0610 00:01:07.042 THREAD126 
> org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
> on slave slave.example.com (id value: 
> "20140519-221756-1772369162-5050-63135-219"
> ) is being assigned task for 
> 1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.
> 
> After:
> 
> I0610 00:01:07.042 THREAD126 
> org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
> on slave slave.example.com (20140519-221756-1772369162-5050-63135-219) is 
> being assigned task for 
> 1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 8e14a76a80e62f2784089ea922e3ad9a2035a7f8 
> 
> Diff: https://reviews.apache.org/r/22408/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L54-L62
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Re: Review Request 22408: Log SlaveID without newline.

2014-06-09 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22408/
---

(Updated June 9, 2014, 6:45 p.m.)


Review request for Aurora, Maxim Khutornenko and Brian Wickman.


Repository: aurora


Description (updated)
---

Log SlaveID without newline.

Before:

I0610 00:01:07.042 THREAD126 
org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
on slave slave.example.com (id value: 
"20140519-221756-1772369162-5050-63135-219"
) is being assigned task for 
1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.

After:

I0610 00:01:07.042 THREAD126 
org.apache.aurora.scheduler.state.TaskAssigner$TaskAssignerImpl.assign: Offer 
on slave slave.example.com (20140519-221756-1772369162-5050-63135-219) is being 
assigned task for 
1402358166917-role-env-name-12345678-f7cb-4664-b7cb-e1a3dc6c283c.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
8e14a76a80e62f2784089ea922e3ad9a2035a7f8 

Diff: https://reviews.apache.org/r/22408/diff/


Testing
---

./gradlew build

https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L54-L62


Thanks,

Kevin Sweeney