Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/
---

(Updated June 20, 2014, 11:05 a.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

ksweeney's comments


Repository: aurora


Description
---

A script to clean out installed dependencies so I don't use the one in twitter 
commons or pantsbuild.


Diffs (updated)
-

  build-support/python/clean.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22747/diff/


Testing
---

It works?


Thanks,

Joe Smith



Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/
---

(Updated June 20, 2014, 11:07 a.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Repository: aurora


Description
---

A script to clean out installed dependencies so I don't use the one in twitter 
commons or pantsbuild.


Diffs (updated)
-

  build-support/python/clean.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22747/diff/


Testing
---

It works?


Thanks,

Joe Smith



Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith


 On June 19, 2014, 11:23 a.m., Kevin Sweeney wrote:
  build-support/python/clean.sh, line 1
  https://reviews.apache.org/r/22747/diff/1/?file=612446#file612446line1
 
  set -ux?

good call.


 On June 19, 2014, 11:23 a.m., Kevin Sweeney wrote:
  build-support/python/clean.sh, lines 3-8
  https://reviews.apache.org/r/22747/diff/1/?file=612446#file612446line3
 
  double-quotes around all non-assignment strings
  
  AURORA_BASE=$(dirname $0)/../..
  rm -fr $HOME/.pex
  rm -fr $AURORA_BASE/.pants.d
  rm -fr $AURORA_BASE/.python
  rm -fr $AURORA_BASE/pants.pex
  
  If you want to see why, try running this script in a directory whose 
  name contains a space like /User/ksweeney/XCode Projects/incubator-aurora 
  (note: don't actually do this).

+1


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/#review46208
---


On June 20, 2014, 11:05 a.m., Joe Smith wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22747/
 ---
 
 (Updated June 20, 2014, 11:05 a.m.)
 
 
 Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 A script to clean out installed dependencies so I don't use the one in 
 twitter commons or pantsbuild.
 
 
 Diffs
 -
 
   build-support/python/clean.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/22747/diff/
 
 
 Testing
 ---
 
 It works?
 
 
 Thanks,
 
 Joe Smith
 




Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/
---

(Updated June 20, 2014, 11:07 a.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Repository: aurora


Description
---

A script to clean out installed dependencies so I don't use the one in twitter 
commons or pantsbuild.


Diffs (updated)
-

  build-support/python/clean.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22747/diff/


Testing
---

It works?


Thanks,

Joe Smith



Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/#review46309
---

Ship it!


Ship It!

- Mark Chu-Carroll


On June 20, 2014, 2:07 p.m., Joe Smith wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22747/
 ---
 
 (Updated June 20, 2014, 2:07 p.m.)
 
 
 Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 A script to clean out installed dependencies so I don't use the one in 
 twitter commons or pantsbuild.
 
 
 Diffs
 -
 
   build-support/python/clean.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/22747/diff/
 
 
 Testing
 ---
 
 It works?
 
 
 Thanks,
 
 Joe Smith
 




Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/#review46351
---

Ship it!


Ship It!

- Brian Wickman


On June 20, 2014, 6:07 p.m., Joe Smith wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22747/
 ---
 
 (Updated June 20, 2014, 6:07 p.m.)
 
 
 Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 A script to clean out installed dependencies so I don't use the one in 
 twitter commons or pantsbuild.
 
 
 Diffs
 -
 
   build-support/python/clean.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/22747/diff/
 
 
 Testing
 ---
 
 It works?
 
 
 Thanks,
 
 Joe Smith