Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46794 --- Ship it! Ship It! - Joe Smith On June 25, 2014, 11:48 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 25, 2014, 11:48 a.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 26, 2014, 8:14 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Changes --- Rebased. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs (updated) - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 3c04773b4eb3fbbca3c41443c571d82c77ec7d58 src/main/python/apache/aurora/client/commands/admin.py 022e3d60c6f2c9c795884577503b052ede6635ba src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 25, 2014, 6:48 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Changes --- CR comments. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs (updated) - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46461 --- Ship it! Ship It! - David McLaughlin On June 20, 2014, 9:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 20, 2014, 9:40 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46479 --- Hm... can we write these unsafe hosts to a file? That'd be very helpful to enable us to come back to it later-on. Right now I'd need to remember to copy-paste the log output (if I'm following right) into another file and re-run src/main/python/apache/aurora/admin/admin_util.py https://reviews.apache.org/r/22842/#comment81863 maybe..? a tuple containing: 1) list of output strings 2) set of hostnames included in output - Joe Smith On June 20, 2014, 2:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 20, 2014, 2:40 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
How about exit non-zero, and re-run the same drain again later if so? -Toby. On Mon, Jun 23, 2014 at 5:25 PM, Joe Smith yasumo...@gmail.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46479 --- Hm... can we write these unsafe hosts to a file? That'd be very helpful to enable us to come back to it later-on. Right now I'd need to remember to copy-paste the log output (if I'm following right) into another file and re-run src/main/python/apache/aurora/admin/admin_util.py https://reviews.apache.org/r/22842/#comment81863 maybe..? a tuple containing: 1) list of output strings 2) set of hostnames included in output - Joe Smith On June 20, 2014, 2:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 20, 2014, 2:40 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
