Re: Review Request 22896: Fix the end-to-end test

2014-06-23 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22896/#review46470
---



examples/vagrant/provision-dev-cluster.sh
https://reviews.apache.org/r/22896/#comment81858

This will fail in a non-git environment. I think you instead want to add 
the --delete-excluded flag to the rsync invocation above.


- Kevin Sweeney


On June 23, 2014, 3:57 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22896/
 ---
 
 (Updated June 23, 2014, 3:57 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-480
 https://issues.apache.org/jira/browse/AURORA-480
 
 
 Repository: aurora
 
 
 Description
 ---
 
 use pants_support_baseurls instead of pants_support_baseurl
 incorporate fix from AURORA-523
 add git clean -fdx so that we don't pull up the wrong pants.pex
 
 
 Diffs
 -
 
   BUILD 24be125b50a883381dc2f9decd0a70e906b007f5 
   examples/vagrant/provision-dev-cluster.sh 
 e08c0deb3fcadedb90a011e917ed49f0c0ac3e35 
   pants.ini 4ecb6f14a68208d55f903001e2edaa012d3c2ed4 
 
 Diff: https://reviews.apache.org/r/22896/diff/
 
 
 Testing
 ---
 
 mba=aurora=; ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 ...
 
 + RETCODE=0
 + collect_result
 + [[ 0 = 0 ]]
 + echo '***'
 ***
 + echo 'OK (all tests passed)'
 OK (all tests passed)
 + echo '***'
 ***
 + exit 0
 
 
 Thanks,
 
 Brian Wickman
 




Re: Review Request 22896: Fix the end-to-end test

2014-06-23 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22896/
---

(Updated June 23, 2014, 11:49 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Add a gitignore --filter statement per 
http://stackoverflow.com/questions/13713101/rsync-exclude-according-to-gitignore-hgignore-svnignore-like-filter-c


Bugs: AURORA-480
https://issues.apache.org/jira/browse/AURORA-480


Repository: aurora


Description
---

use pants_support_baseurls instead of pants_support_baseurl
incorporate fix from AURORA-523
add git clean -fdx so that we don't pull up the wrong pants.pex


Diffs (updated)
-

  examples/vagrant/provision-dev-cluster.sh 
e08c0deb3fcadedb90a011e917ed49f0c0ac3e35 
  pants.ini 4ecb6f14a68208d55f903001e2edaa012d3c2ed4 

Diff: https://reviews.apache.org/r/22896/diff/


Testing
---

mba=aurora=; ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

...

+ RETCODE=0
+ collect_result
+ [[ 0 = 0 ]]
+ echo '***'
***
+ echo 'OK (all tests passed)'
OK (all tests passed)
+ echo '***'
***
+ exit 0


Thanks,

Brian Wickman



Re: Review Request 22896: Fix the end-to-end test

2014-06-23 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22896/#review46477
---

Ship it!


Ship It!

- Joe Smith


On June 23, 2014, 4:49 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22896/
 ---
 
 (Updated June 23, 2014, 4:49 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-480
 https://issues.apache.org/jira/browse/AURORA-480
 
 
 Repository: aurora
 
 
 Description
 ---
 
 use pants_support_baseurls instead of pants_support_baseurl
 incorporate fix from AURORA-523
 add git clean -fdx so that we don't pull up the wrong pants.pex
 
 
 Diffs
 -
 
   examples/vagrant/provision-dev-cluster.sh 
 e08c0deb3fcadedb90a011e917ed49f0c0ac3e35 
   pants.ini 4ecb6f14a68208d55f903001e2edaa012d3c2ed4 
 
 Diff: https://reviews.apache.org/r/22896/diff/
 
 
 Testing
 ---
 
 mba=aurora=; ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 ...
 
 + RETCODE=0
 + collect_result
 + [[ 0 = 0 ]]
 + echo '***'
 ***
 + echo 'OK (all tests passed)'
 OK (all tests passed)
 + echo '***'
 ***
 + exit 0
 
 
 Thanks,
 
 Brian Wickman
 




Re: Review Request 22896: Fix the end-to-end test

2014-06-23 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22896/#review46478
---

Ship it!


Ship It!

- Kevin Sweeney


On June 23, 2014, 4:49 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22896/
 ---
 
 (Updated June 23, 2014, 4:49 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-480
 https://issues.apache.org/jira/browse/AURORA-480
 
 
 Repository: aurora
 
 
 Description
 ---
 
 use pants_support_baseurls instead of pants_support_baseurl
 incorporate fix from AURORA-523
 add git clean -fdx so that we don't pull up the wrong pants.pex
 
 
 Diffs
 -
 
   examples/vagrant/provision-dev-cluster.sh 
 e08c0deb3fcadedb90a011e917ed49f0c0ac3e35 
   pants.ini 4ecb6f14a68208d55f903001e2edaa012d3c2ed4 
 
 Diff: https://reviews.apache.org/r/22896/diff/
 
 
 Testing
 ---
 
 mba=aurora=; ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 ...
 
 + RETCODE=0
 + collect_result
 + [[ 0 = 0 ]]
 + echo '***'
 ***
 + echo 'OK (all tests passed)'
 OK (all tests passed)
 + echo '***'
 ***
 + exit 0
 
 
 Thanks,
 
 Brian Wickman