Re: Review Request 23144: Switching from getTasksStatus to getTasksWithoutConfigs.

2014-07-18 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23144/#review48136
---

Ship it!


Ship It!

- Mark Chu-Carroll


On June 27, 2014, 7:44 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23144/
 ---
 
 (Updated June 27, 2014, 7:44 p.m.)
 
 
 Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
 
 
 Bugs: AURORA-553
 https://issues.apache.org/jira/browse/AURORA-553
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Switching from getTasksStatus to getTasksWithoutConfigs (with ExecutorConfig 
 set to null) RPC. 
 
 The only places where ExecutorConfig is still required are: 
 - updater 
 - diff 
 - command runner (e.g. ssh)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/__init__.py 
 81c430e4a168585e757b72088d29e9d669eecb3f 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 e09aa9a6c32c17f13c9b8ff3a589919587bd839b 
   src/main/python/apache/aurora/client/api/job_monitor.py 
 d176995fca68d42fcc2d3989483eaf520d0d737f 
   src/main/python/apache/aurora/client/api/restarter.py 
 e843fc32ee6f60aa0b080d530d75f227635b99ba 
   src/main/python/apache/aurora/client/api/scheduler_client.py 
 10a956c50de893c8380ef1f763ed7d6686b5c00c 
   src/main/python/apache/aurora/client/api/sla.py 
 8fc9af329a726087c0f93fae975298e042c25d8b 
   src/main/python/apache/aurora/client/cli/jobs.py 
 4fa03a6c9919651551238b0dc211ed69a8dfe565 
   src/main/python/apache/aurora/client/commands/core.py 
 0939f0570572375ba9b4d054ddb9849995c9048d 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 723a5b6f429f85202ee4ad3a004f019cec632a98 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3aa96075e085ac7c2607a8c303ee5daf6e3e43b0 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 97add6ff3ff4f894f069594c76bcdcd7f80630d5 
   src/test/python/apache/aurora/client/api/test_sla.py 
 abeed6a610db3a75505173a0e657812af8b31a1a 
   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
 bf723835f19e6e359b928b57c214c3df5d130515 
   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
 65bce5f9444ad48aa520ff1217a1400c523b8518 
   src/test/python/apache/aurora/client/cli/test_create.py 
 b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
   src/test/python/apache/aurora/client/cli/test_kill.py 
 e9e167991cd06e556dbbc839eb9a808eb7d88fe9 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 ce85318727dcaf22a696d05f99c49b5e953bd3ca 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 407eb41eb6e78721ef29baefdee5699e605193f9 
   src/test/python/apache/aurora/client/cli/test_status.py 
 bdad310ca95800d08f9bf134bb8fdb15dffbbc12 
   src/test/python/apache/aurora/client/cli/test_update.py 
 44a180e88893fea1d7acf1862d5aaa95d98598f5 
   src/test/python/apache/aurora/client/cli/util.py 
 a2c9d09c58243250baefab2ee51f5ea3b411 
   src/test/python/apache/aurora/client/commands/test_create.py 
 4cd1343b19e9d13abe20d3b88dc7460ec512d57b 
   src/test/python/apache/aurora/client/commands/test_hooks.py 
 0c76aea569bb862b802f49dea918ae5102afa700 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 94bbe1bfff1c8d333837aa6bb14700714f46288b 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 0c6d5a069c43d96098c126aa340a734cb37c667a 
   src/test/python/apache/aurora/client/commands/test_status.py 
 a5c0ef0fd9547d73bda5639cdb85ea41973518d7 
   src/test/python/apache/aurora/client/commands/test_update.py 
 ea8e092267fd65ccd24ca1be3c04f50ba89f5236 
 
 Diff: https://reviews.apache.org/r/23144/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python:all
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 23144: Switching from getTasksStatus to getTasksWithoutConfigs.

2014-07-03 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23144/#review47307
---

Ship it!


Ship It!

- Brian Wickman


On June 27, 2014, 11:44 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23144/
 ---
 
 (Updated June 27, 2014, 11:44 p.m.)
 
 
 Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
 
 
 Bugs: AURORA-553
 https://issues.apache.org/jira/browse/AURORA-553
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Switching from getTasksStatus to getTasksWithoutConfigs (with ExecutorConfig 
 set to null) RPC. 
 
 The only places where ExecutorConfig is still required are: 
 - updater 
 - diff 
 - command runner (e.g. ssh)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/__init__.py 
 81c430e4a168585e757b72088d29e9d669eecb3f 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 e09aa9a6c32c17f13c9b8ff3a589919587bd839b 
   src/main/python/apache/aurora/client/api/job_monitor.py 
 d176995fca68d42fcc2d3989483eaf520d0d737f 
   src/main/python/apache/aurora/client/api/restarter.py 
 e843fc32ee6f60aa0b080d530d75f227635b99ba 
   src/main/python/apache/aurora/client/api/scheduler_client.py 
 10a956c50de893c8380ef1f763ed7d6686b5c00c 
   src/main/python/apache/aurora/client/api/sla.py 
 8fc9af329a726087c0f93fae975298e042c25d8b 
   src/main/python/apache/aurora/client/cli/jobs.py 
 4fa03a6c9919651551238b0dc211ed69a8dfe565 
   src/main/python/apache/aurora/client/commands/core.py 
 0939f0570572375ba9b4d054ddb9849995c9048d 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 723a5b6f429f85202ee4ad3a004f019cec632a98 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3aa96075e085ac7c2607a8c303ee5daf6e3e43b0 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 97add6ff3ff4f894f069594c76bcdcd7f80630d5 
   src/test/python/apache/aurora/client/api/test_sla.py 
 abeed6a610db3a75505173a0e657812af8b31a1a 
   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
 bf723835f19e6e359b928b57c214c3df5d130515 
   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
 65bce5f9444ad48aa520ff1217a1400c523b8518 
   src/test/python/apache/aurora/client/cli/test_create.py 
 b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
   src/test/python/apache/aurora/client/cli/test_kill.py 
 e9e167991cd06e556dbbc839eb9a808eb7d88fe9 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 ce85318727dcaf22a696d05f99c49b5e953bd3ca 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 407eb41eb6e78721ef29baefdee5699e605193f9 
   src/test/python/apache/aurora/client/cli/test_status.py 
 bdad310ca95800d08f9bf134bb8fdb15dffbbc12 
   src/test/python/apache/aurora/client/cli/test_update.py 
 44a180e88893fea1d7acf1862d5aaa95d98598f5 
   src/test/python/apache/aurora/client/cli/util.py 
 a2c9d09c58243250baefab2ee51f5ea3b411 
   src/test/python/apache/aurora/client/commands/test_create.py 
 4cd1343b19e9d13abe20d3b88dc7460ec512d57b 
   src/test/python/apache/aurora/client/commands/test_hooks.py 
 0c76aea569bb862b802f49dea918ae5102afa700 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 94bbe1bfff1c8d333837aa6bb14700714f46288b 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 0c6d5a069c43d96098c126aa340a734cb37c667a 
   src/test/python/apache/aurora/client/commands/test_status.py 
 a5c0ef0fd9547d73bda5639cdb85ea41973518d7 
   src/test/python/apache/aurora/client/commands/test_update.py 
 ea8e092267fd65ccd24ca1be3c04f50ba89f5236 
 
 Diff: https://reviews.apache.org/r/23144/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python:all
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 23144: Switching from getTasksStatus to getTasksWithoutConfigs.

2014-07-02 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23144/#review47226
---


Ping Brian, Mark.

- Maxim Khutornenko


On June 27, 2014, 11:44 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23144/
 ---
 
 (Updated June 27, 2014, 11:44 p.m.)
 
 
 Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
 
 
 Bugs: AURORA-553
 https://issues.apache.org/jira/browse/AURORA-553
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Switching from getTasksStatus to getTasksWithoutConfigs (with ExecutorConfig 
 set to null) RPC. 
 
 The only places where ExecutorConfig is still required are: 
 - updater 
 - diff 
 - command runner (e.g. ssh)
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/__init__.py 
 81c430e4a168585e757b72088d29e9d669eecb3f 
   src/main/python/apache/aurora/client/api/instance_watcher.py 
 e09aa9a6c32c17f13c9b8ff3a589919587bd839b 
   src/main/python/apache/aurora/client/api/job_monitor.py 
 d176995fca68d42fcc2d3989483eaf520d0d737f 
   src/main/python/apache/aurora/client/api/restarter.py 
 e843fc32ee6f60aa0b080d530d75f227635b99ba 
   src/main/python/apache/aurora/client/api/scheduler_client.py 
 10a956c50de893c8380ef1f763ed7d6686b5c00c 
   src/main/python/apache/aurora/client/api/sla.py 
 8fc9af329a726087c0f93fae975298e042c25d8b 
   src/main/python/apache/aurora/client/cli/jobs.py 
 4fa03a6c9919651551238b0dc211ed69a8dfe565 
   src/main/python/apache/aurora/client/commands/core.py 
 0939f0570572375ba9b4d054ddb9849995c9048d 
   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
 723a5b6f429f85202ee4ad3a004f019cec632a98 
   src/test/python/apache/aurora/client/api/test_job_monitor.py 
 3aa96075e085ac7c2607a8c303ee5daf6e3e43b0 
   src/test/python/apache/aurora/client/api/test_restarter.py 
 97add6ff3ff4f894f069594c76bcdcd7f80630d5 
   src/test/python/apache/aurora/client/api/test_sla.py 
 abeed6a610db3a75505173a0e657812af8b31a1a 
   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
 bf723835f19e6e359b928b57c214c3df5d130515 
   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
 65bce5f9444ad48aa520ff1217a1400c523b8518 
   src/test/python/apache/aurora/client/cli/test_create.py 
 b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
   src/test/python/apache/aurora/client/cli/test_kill.py 
 e9e167991cd06e556dbbc839eb9a808eb7d88fe9 
   src/test/python/apache/aurora/client/cli/test_plugins.py 
 ce85318727dcaf22a696d05f99c49b5e953bd3ca 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 407eb41eb6e78721ef29baefdee5699e605193f9 
   src/test/python/apache/aurora/client/cli/test_status.py 
 bdad310ca95800d08f9bf134bb8fdb15dffbbc12 
   src/test/python/apache/aurora/client/cli/test_update.py 
 44a180e88893fea1d7acf1862d5aaa95d98598f5 
   src/test/python/apache/aurora/client/cli/util.py 
 a2c9d09c58243250baefab2ee51f5ea3b411 
   src/test/python/apache/aurora/client/commands/test_create.py 
 4cd1343b19e9d13abe20d3b88dc7460ec512d57b 
   src/test/python/apache/aurora/client/commands/test_hooks.py 
 0c76aea569bb862b802f49dea918ae5102afa700 
   src/test/python/apache/aurora/client/commands/test_kill.py 
 94bbe1bfff1c8d333837aa6bb14700714f46288b 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 0c6d5a069c43d96098c126aa340a734cb37c667a 
   src/test/python/apache/aurora/client/commands/test_status.py 
 a5c0ef0fd9547d73bda5639cdb85ea41973518d7 
   src/test/python/apache/aurora/client/commands/test_update.py 
 ea8e092267fd65ccd24ca1be3c04f50ba89f5236 
 
 Diff: https://reviews.apache.org/r/23144/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python:all
 
 
 Thanks,
 
 Maxim Khutornenko