Re: Review Request 23219: Instruct quartz to use all daemon threads.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23219/#review47271 --- Ship it! Ship It! - Maxim Khutornenko On July 2, 2014, 12:47 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23219/ > --- > > (Updated July 2, 2014, 12:47 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-560 > https://issues.apache.org/jira/browse/AURORA-560 > > > Repository: aurora > > > Description > --- > > Instruct quartz to use all daemon threads. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 88cb360cf472a20e837433998d3c2ea84e119498 > > Diff: https://reviews.apache.org/r/23219/diff/ > > > Testing > --- > > Unfortunately this is a tough one to test. Tests pass, but nothing prevents > regression. I'm open to ideas on this, but nothing appealing comes to mind. > > I did manually test in the way that i first noticed the issue, and the > scheduler no longer hangs when tearing down. > > > Thanks, > > Bill Farner > >
Re: Review Request 23219: Instruct quartz to use all daemon threads.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23219/#review47260 --- Ping - Maxim? - Bill Farner On July 2, 2014, 12:47 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23219/ > --- > > (Updated July 2, 2014, 12:47 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-560 > https://issues.apache.org/jira/browse/AURORA-560 > > > Repository: aurora > > > Description > --- > > Instruct quartz to use all daemon threads. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 88cb360cf472a20e837433998d3c2ea84e119498 > > Diff: https://reviews.apache.org/r/23219/diff/ > > > Testing > --- > > Unfortunately this is a tough one to test. Tests pass, but nothing prevents > regression. I'm open to ideas on this, but nothing appealing comes to mind. > > I did manually test in the way that i first noticed the issue, and the > scheduler no longer hangs when tearing down. > > > Thanks, > > Bill Farner > >
Re: Review Request 23219: Instruct quartz to use all daemon threads.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23219/#review47161 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 5:47 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23219/ > --- > > (Updated July 1, 2014, 5:47 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-560 > https://issues.apache.org/jira/browse/AURORA-560 > > > Repository: aurora > > > Description > --- > > Instruct quartz to use all daemon threads. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 88cb360cf472a20e837433998d3c2ea84e119498 > > Diff: https://reviews.apache.org/r/23219/diff/ > > > Testing > --- > > Unfortunately this is a tough one to test. Tests pass, but nothing prevents > regression. I'm open to ideas on this, but nothing appealing comes to mind. > > I did manually test in the way that i first noticed the issue, and the > scheduler no longer hangs when tearing down. > > > Thanks, > > Bill Farner > >
