Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48427 --- Ship it! Ship It! src/main/python/apache/aurora/admin/host_mainte

Re: Review Request 23244: Fixing return value in _check_sla.

> On July 22, 2014, 8:07 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 131 > > > > > > Oh, I see. So why not just do "if host_groups and len(host_groups) > 1"? > > The

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 22, 2014, 8:40 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48418 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 23244: Fixing return value in _check_sla.

> On July 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 131 > > > > > > What is this initialization doing? I don't see what it changes - it's > > reassi

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48415 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 22, 2014, 4:41 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 21, 2014, 9:39 p.m.) Review request for Aurora, Joe Smith and Mar