Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review49501 --- sorry for the radio silence on this -- vacation + other work. will

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated Aug. 4, 2014, 9:14 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review49517 --- Neglected to catch this in previous rounds, but can you add a

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated Aug. 4, 2014, 11:01 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated Aug. 4, 2014, 11:02 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review49526 --- Ship it! Ship It! - Bill Farner On Aug. 4, 2014, 11:02 p.m.,

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-08-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review49527 --- Ship it! Ship It! - Kevin Sweeney On Aug. 4, 2014, 4:02 p.m.,

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review48767 --- src/test/sh/org/apache/aurora/e2e/test_common.sh

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated July 24, 2014, 9:43 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review48684 --- Ship it! src/test/sh/org/apache/aurora/e2e/test_common.sh

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated July 24, 2014, 10:32 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review48593 --- Ship it! Good start, thanks for getting this out here. Any

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Bill Farner
On July 24, 2014, 12:40 a.m., Kevin Sweeney wrote: Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Kevin Sweeney
On July 23, 2014, 5:40 p.m., Kevin Sweeney wrote: Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated July 24, 2014, 2:36 a.m.) Review request for Aurora, Kevin Sweeney