Re: Review Request 24655: Implementing startJobUpdate thrift API.
On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java, line 27 https://reviews.apache.org/r/24655/diff/1/?file=659429#file659429line27 s/User/User who/ Done. On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java, line 96 https://reviews.apache.org/r/24655/diff/1/?file=659430#file659430line96 requireNonNull for all 3 Done. On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java, line 42 https://reviews.apache.org/r/24655/diff/1/?file=659429#file659429line42 I tend to prefer the String, Throwable signature, allowing (read: encouraging) layers in the stack to add context. Done. On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1259 https://reviews.apache.org/r/24655/diff/1/?file=659432#file659432line1259 TODO: input validation. It might not happen here, but good to leave a reminder. Thanks for reminding. Added. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/#review50594 --- On Aug. 13, 2014, 5:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/ --- (Updated Aug. 13, 2014, 5:32 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing startJobUpdate thrift API. Diffs - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/StateModule.java 2c712eff097c3334bfcf2559a52214367748d08a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/24655/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24655: Implementing startJobUpdate thrift API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/ --- (Updated Aug. 14, 2014, 8:07 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Changes --- CR comments. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing startJobUpdate thrift API. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/StateModule.java 2c712eff097c3334bfcf2559a52214367748d08a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/24655/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24655: Implementing startJobUpdate thrift API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/#review50661 --- Ship it! Ship It! - David McLaughlin On Aug. 14, 2014, 8:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/ --- (Updated Aug. 14, 2014, 8:07 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing startJobUpdate thrift API. Diffs - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/StateModule.java 2c712eff097c3334bfcf2559a52214367748d08a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/24655/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
