Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
On Aug. 15, 2014, 6:02 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 558 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line558 Rolling back assumes removing new (INSTANCE_REMOVED) and adding old (INSTANCE_ADDED). Do we

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Maxim Khutornenko
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 18, 2014, 5:49 p.m.) Review request for Aurora, Maxim

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50910 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 18, 2014, 5:49

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50911 --- Ship it! Ship It! - Bill Farner On Aug. 18, 2014, 5:49 p.m.,

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 18, 2014, 5:59 p.m.) Review request for Aurora, Maxim

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 15, 2014, 5:52 p.m.) Review request for Aurora, Maxim

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50752 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread David McLaughlin
On Aug. 15, 2014, 6:02 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 558 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line558 Rolling back assumes removing new (INSTANCE_REMOVED) and adding old (INSTANCE_ADDED). Do we

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50805 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50679 --- Ship it! src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50692 --- Also, while it might seem tedious, can you include in the