Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/ --- (Updated Aug. 22, 2014, 11:04 a.m.) Review request for Aurora, David

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50974 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Mark Chu-Carroll
On Aug. 19, 2014, 11:47 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 119-121 https://reviews.apache.org/r/24852/diff/1/?file=664290#file664290line119 General question: what happens to a message returned by the response in case of error?

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50981 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 19, 2014, 3:22

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Mark Chu-Carroll
On Aug. 19, 2014, 11:47 a.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 https://reviews.apache.org/r/24852/diff/1/?file=664291#file664291line233 This is the existing test, right? Diff shows it in green for some reason...

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
On Aug. 19, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 https://reviews.apache.org/r/24852/diff/1/?file=664291#file664291line233 This is the existing test, right? Diff shows it in green for some reason...

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50994 --- Ship it! Ship It! - David McLaughlin On Aug. 19, 2014, 3:22