Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:06 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Hide the latest updates content box entirely when there are no updates. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53555 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment93245 ...forward roll. - this is no longer correct as we use this setting for both forward and back roll. Mind updating this and api.thrift? - Maxim Khutornenko On Sept. 16, 2014, 6:06 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:06 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:29 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Modified the maxFailedInstances description. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 16, 2014, 6:12 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 41 https://reviews.apache.org/r/25259/diff/9/?file=690739#file690739line41 ...forward roll. - this is no longer correct as we use this setting for both forward and back roll. Mind updating this and api.thrift? Done. Can you confirm you're okay with the updated description? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53555 --- On Sept. 16, 2014, 6:29 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:29 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53570 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js https://reviews.apache.org/r/25259/#comment93272 I think you can use .constant here and drop the top-level function () - Kevin Sweeney On Sept. 16, 2014, 11:29 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 11:29 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 16, 2014, 6:12 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 41 https://reviews.apache.org/r/25259/diff/9/?file=690739#file690739line41 ...forward roll. - this is no longer correct as we use this setting for both forward and back roll. Mind updating this and api.thrift? David McLaughlin wrote: Done. Can you confirm you're okay with the updated description? lgtm - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53555 --- On Sept. 16, 2014, 6:29 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:29 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53422 --- Ship it! Thanks for adding those subset-related comments, clearer now! src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js https://reviews.apache.org/r/25259/#comment93077 Nitpick: I'd name this subset param so it doesn't collide w/ the subset var above, just for extra future-safety. - Joshua Cohen On Sept. 15, 2014, 6:53 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 15, 2014, 6:53 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 12:30 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- rebase. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 12:32 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Rebase went slightly wrong due to the mocked out data commits I have. Fixed. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review53216
---
Mostly just nitpicky style/readability stuff...
src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
https://reviews.apache.org/r/25259/#comment92717
This might read a little bit cleaner if you chained it all?
return instanceActionLookup[action] || 'UNKNOWN'
.replace(/INSTANCE_/, '')
.replace(/_/g, ' ');
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
https://reviews.apache.org/r/25259/#comment92719
I'm unclear on the need to convert these arrays of statuses above to
objects just to check for the presence of a value? Is there a reason we can't
simply use indexOf on the array and save the transform?
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
https://reviews.apache.org/r/25259/#comment92723
just inline instanceActionLookup[action] here?
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
https://reviews.apache.org/r/25259/#comment92725
given the similarity to the reverse events iteration in
`progressFromEvents` above it might be worthwhile to extract a function like
(but with a better name...):
function reverseEventsFilter(instanceEvents, condition) {
var events = _.sortBy(instanceEvents, 'timestampMs');
var instanceMap = {};
condition = condition || function() {};
for (var i = events.length - 1; i = 0; i++) {
if (instanceMap.hasOwnProperty(events[i].instanceId)
condition(event)) {
instanceMap[event.instanceId] = event;
}
}
return instanceMap;
}
Then the logic here just becomes:
var instanceMap = reverseEventsFilter(details.instanceEvents);
And the logic above in `progressFromEvents` becomes something like:
return Object.keys(reverseEventsFilter(instanceEvents, function(e) {
updateUtil.isInstanceSuccessful(e.action); })).length;
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
https://reviews.apache.org/r/25259/#comment92727
kill blank line.
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
https://reviews.apache.org/r/25259/#comment92726
isSubset checks to make sure subset is truthy, and since it's iterating to
subset.length we can probably skip both of these checks and just make this `if
(inSubset(i))`
Also, how do you feel about passing subset in as a param to isSubset
instead of picking it up via a closure?
- Joshua Cohen
On Sept. 9, 2014, 11:50 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/
---
(Updated Sept. 9, 2014, 11:50 p.m.)
Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-614
https://issues.apache.org/jira/browse/AURORA-614
Repository: aurora
Description
---
Adds update history to the job page. Adds an update details page.
Diffs
-
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
de49a1c5497e32ee4db944412e5c87807c742d3c
src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html
c780b0fe98863b5421824a9652a7202da9f4302a
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css
2a752313cb8ae404605a9458b33237a911eec061
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html
e21dee015897eee62ade8f74e26f042b8e2be734
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js
fb3b5b12121a6e8a30dbf6fe069557f69a563408
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
3477b7e667459665af9d9dc9d2456793822bc7f7
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
7f05a552f3786adb115ff9648f4fadce968230e9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
df2806481fc1c2f263d3afd9b21247e97a18ed57
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
bfd360de45c75441743c8ba24a5c445f4146dba6
src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/update.html
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html
PRE-CREATION
src/main/thrift/org/apache/aurora/gen/api.thrift
2b376d663b3bc9264965db58ef89de59b10169ad
Diff: https://reviews.apache.org/r/25259/diff/
Testing
---
./gradlew jsHint
File Attachments
job page
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 12, 2014, 10:39 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Forgot to run jshint + forgot to refactor one of the event parsing functions. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53244 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js https://reviews.apache.org/r/25259/#comment92799 I'd like to see the paused states disambiguated. I could imagine a user resuming an update and being surprised by the direction the update moves. src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js https://reviews.apache.org/r/25259/#comment92818 TODO(davmclau) src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html https://reviews.apache.org/r/25259/#comment92796 I'd love to see UTC here as well. src/main/resources/org/apache/aurora/scheduler/http/ui/update.html https://reviews.apache.org/r/25259/#comment92798 Is the indenting off here? src/main/resources/org/apache/aurora/scheduler/http/ui/update.html https://reviews.apache.org/r/25259/#comment92797 For my own edification - is there a pattern being followed w.r.t. newlines here? I thought i had the style figured out until here. - Bill Farner On Sept. 12, 2014, 10:39 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 12, 2014, 10:39 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52665 --- src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/25259/#comment91559 Extract this as a configuration variable? src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/25259/#comment91560 DRY src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js https://reviews.apache.org/r/25259/#comment91829 Since this has no dependencies you can make it .constant - Kevin Sweeney On Sept. 8, 2014, 6:05 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 8, 2014, 6:05 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 277 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277 This seems to be too short to make any visual difference but could be a perf hit. How about 10-15sec instead? Also, is there any visual cue that the progress is auto-updated? Maxim Khutornenko wrote: Also, will the auto-update get suspended when the page is out of focus (e.g. user switches to another tab or hides the browser)? Would be great if it does. No visual cue that it's auto-updated. It could be something to add in the future, or do you see it as a blocker for this? I picked 3s off the top of my head. 10s sounds like a good alternative. Auto-update being suspended when the page is out of focus doesn't seem like a desired feature. When I come back to the tab the page is always in the same state as I last saw it. There is definitely a use case of tabbing in and out to see how an update is going. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line 54 https://reviews.apache.org/r/25259/diff/1/?file=683448#file683448line54 Should not this be ROLL BACK PAUSED instead? I figured the user didn't really care about what type of pause it was, and the previous state is right there in the status history. Thoughts? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 --- On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 1:05 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 277 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277 This seems to be too short to make any visual difference but could be a perf hit. How about 10-15sec instead? Also, is there any visual cue that the progress is auto-updated? Maxim Khutornenko wrote: Also, will the auto-update get suspended when the page is out of focus (e.g. user switches to another tab or hides the browser)? Would be great if it does. David McLaughlin wrote: No visual cue that it's auto-updated. It could be something to add in the future, or do you see it as a blocker for this? I picked 3s off the top of my head. 10s sounds like a good alternative. Auto-update being suspended when the page is out of focus doesn't seem like a desired feature. When I come back to the tab the page is always in the same state as I last saw it. There is definitely a use case of tabbing in and out to see how an update is going. | When I come back to the tab the page is always in the same state as I last saw it. Is it possible to suspend auto-update on lost focus and resume on re-acquiring it? Not sure if there is a high level event available for it but would be great to avoid wasted expensive queries on the scheduler if no one is watching the page. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 --- On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 1:05 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 277 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277 Extract this as a configuration variable? Fixed. On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 411 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line411 DRY Fixed. On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 156 https://reviews.apache.org/r/25259/diff/1/?file=683449#file683449line156 Since this has no dependencies you can make it .constant This is defined how taskUtil is for consistency. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52665 --- On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 1:05 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 11:32 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- rb feedback. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 277 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277 This seems to be too short to make any visual difference but could be a perf hit. How about 10-15sec instead? Also, is there any visual cue that the progress is auto-updated? Maxim Khutornenko wrote: Also, will the auto-update get suspended when the page is out of focus (e.g. user switches to another tab or hides the browser)? Would be great if it does. David McLaughlin wrote: No visual cue that it's auto-updated. It could be something to add in the future, or do you see it as a blocker for this? I picked 3s off the top of my head. 10s sounds like a good alternative. Auto-update being suspended when the page is out of focus doesn't seem like a desired feature. When I come back to the tab the page is always in the same state as I last saw it. There is definitely a use case of tabbing in and out to see how an update is going. Maxim Khutornenko wrote: | When I come back to the tab the page is always in the same state as I last saw it. Is it possible to suspend auto-update on lost focus and resume on re-acquiring it? Not sure if there is a high level event available for it but would be great to avoid wasted expensive queries on the scheduler if no one is watching the page. The problem with tabs/windows is they can be inactive but still visible in your screen. e.g. there's no way to know if the inactive window is hidden behind another window or still visible on a second screen. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 411 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line411 Same here. Fixed. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 31 https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line31 Missing period. Fixed. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 32 https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line32 s/Instances/Instance Fixed. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 41 https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line41 Missing period. Fixed. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 61 https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line61 s/to watch to watch/to watch Just realized it's copied from api.thrift. Mind fixing it there as well? Fixed. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 62 https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line62 Suggest renaming to Min Waiting Time In Running to better reflect on the setting. Fixed. On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 81 https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line81 s/set/subset? Also, suggest adding: All instances will be affected if this is not set. Fixed. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 --- On Sept. 9, 2014, 11:32 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 11:32 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 11:50 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Fixed typo. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 9, 2014, 11:42 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, line 81 https://reviews.apache.org/r/25259/diff/1-2/?file=683452#file683452line81 s/is this/if this D'oh. Fixed. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52801 --- On Sept. 9, 2014, 11:50 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 11:50 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 --- src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/25259/#comment91561 This seems to be too short to make any visual difference but could be a perf hit. How about 10-15sec instead? Also, is there any visual cue that the progress is auto-updated? src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/25259/#comment91567 Same here. src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js https://reviews.apache.org/r/25259/#comment91570 Should not this be ROLL BACK PAUSED instead? src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment91554 Missing period. src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment91555 s/Instances/Instance src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment91553 Missing period. src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment91548 s/to watch to watch/to watch Just realized it's copied from api.thrift. Mind fixing it there as well? src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment91551 Suggest renaming to Min Waiting Time In Running to better reflect on the setting. src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html https://reviews.apache.org/r/25259/#comment91552 s/set/subset? Also, suggest adding: All instances will be affected if this is not set. - Maxim Khutornenko On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 1:05 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
Re: Review Request 25259: Add update information to the scheduler UI
On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 277 https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277 This seems to be too short to make any visual difference but could be a perf hit. How about 10-15sec instead? Also, is there any visual cue that the progress is auto-updated? Also, will the auto-update get suspended when the page is out of focus (e.g. user switches to another tab or hides the browser)? Would be great if it does. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 --- On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 1:05 a.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-614 https://issues.apache.org/jira/browse/AURORA-614 Repository: aurora Description --- Adds update history to the job page. Adds an update details page. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js df2806481fc1c2f263d3afd9b21247e97a18ed57 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6 src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION Diff: https://reviews.apache.org/r/25259/diff/ Testing --- ./gradlew jsHint File Attachments job page https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png update page https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png Thanks, David McLaughlin
