----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25350/#review52341 -----------------------------------------------------------
Ship it! Can you change the subject of the review to be more specific? This isn't very friendly when scanning the commit log. src/test/python/apache/aurora/client/cli/test_status.py <https://reviews.apache.org/r/25350/#comment91105> TODO inject a fake clock? - Bill Farner On Sept. 4, 2014, 7:45 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25350/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 7:45 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: aurora-684 > https://issues.apache.org/jira/browse/aurora-684 > > > Repository: aurora > > > Description > ------- > > Timestamps in pretty-printed job status use the local timezone. > Jenkins machines use GMT as their local time; so the time printed > on jenkins differs from times printed elsewhere. > > This fix fuzzes out the time in the timestamps, so that it doesn't matter > where the test is run. > > > Diffs > ----- > > src/test/python/apache/aurora/client/cli/test_status.py > 2af24fbaa4971819636898df752fa886553d75a3 > > Diff: https://reviews.apache.org/r/25350/diff/ > > > Testing > ------- > > > Thanks, > > Mark Chu-Carroll > >