Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52958 --- Ship it! Ship It! - Bill Farner On Sept. 9, 2014, 4:54 p.m.,

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-10 Thread Bill Farner
On Sept. 10, 2014, 10:15 p.m., Bill Farner wrote: Ship It! Thanks! This is now on master: ``` commit cc70136 Author: Joshua Cohen jco...@twopensource.com Date: Wed Sep 10 15:38:56 2014 -0700 Make the offer hold jitter window configurable. Bugs closed: AURORA-313

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52735 ---

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/ --- (Updated Sept. 9, 2014, 4:54 p.m.) Review request for Aurora, Maxim

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-09 Thread Joshua Cohen
On Sept. 9, 2014, 4:45 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java, line 53 https://reviews.apache.org/r/25398/diff/3/?file=682822#file682822line53 Consider using the mock throughout. You get a little extra bit of

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52613 --- src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/ --- (Updated Sept. 8, 2014, 5:54 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/ --- (Updated Sept. 8, 2014, 5:55 p.m.) Review request for Aurora, Maxim

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52630 --- Ship it!

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
On Sept. 8, 2014, 8:41 p.m., Maxim Khutornenko wrote: src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java, line 71 https://reviews.apache.org/r/25398/diff/2/?file=682734#file682734line71 How about a assertRandomJitterReturnDelay(0, 0) test? Added.

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/ --- (Updated Sept. 8, 2014, 9:09 p.m.) Review request for Aurora, Maxim

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52514 --- Mind exposing RandomJitterReturnDelay and adding a unit test?

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-05 Thread Joshua Cohen
On Sept. 5, 2014, 9:44 p.m., Bill Farner wrote: Mind exposing RandomJitterReturnDelay and adding a unit test? You'll need a way to plumb in your own Random as well. Yeah, I mulled that over, but was wary of exposing it. Happy to to do so though. - Joshua