subject:"Re\: Review Request 25466\: Upgrade Aurora to psutil 2.1.1"

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-23 Thread Jake Farrell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review54282
---


psutil 2.1.2 now available, since we are upgrading here might as well go with 
the latest version

https://github.com/giampaolo/psutil/blob/master/HISTORY.rst

- Jake Farrell


On Sept. 9, 2014, 6:38 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25466/
> ---
> 
> (Updated Sept. 9, 2014, 6:38 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-412
> https://issues.apache.org/jira/browse/AURORA-412
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade Aurora to psutil 2.1.1
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7665a77ca13bbbc337e345356b70f12357692f3d 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 572c106038602b795a5b6bf08b2b85cf4b6bfec6 
>   src/main/python/apache/thermos/core/helper.py 
> 9e4a8fb70df984d175129cb49025b3c222a64679 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> 298459bab01d2c01bef1d69c1150ff2d5737ebbf 
>   src/test/python/apache/thermos/core/test_helper.py 
> 58096119e1b412afa36a09da5759c5223a5b5d75 
> 
> Diff: https://reviews.apache.org/r/25466/diff/
> 
> 
> Testing
> ---
> 
> Ran tests on OS X but not yet on Linux.  There is adequate coverage.
> 
> ==edit, Linux test output==
> 
> src.test.python.apache.thermos.bin.test_thermos   
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_pathspec   
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_planner
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_task_planner   
>   .   SUCCESS
> src.test.python.apache.thermos.config.test_schema 
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_angry
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_ephemerals   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_failing_runner   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_failure_limit
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_finalization 
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_helper   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_process  
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_runner_integration   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_staged_kill  
>   .   SUCCESS
> src.test.python.apache.thermos.monitoring.test_disk   
>   .   SUCCESS
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks
>   .   SUCCESS
>

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-09 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/
---

(Updated Sept. 9, 2014, 6:38 p.m.)


Review request for Aurora, Joe Smith and Kevin Sweeney.


Changes
---

Address Kevin's feedback.


Bugs: AURORA-412
https://issues.apache.org/jira/browse/AURORA-412


Repository: aurora


Description
---

Upgrade Aurora to psutil 2.1.1


Diffs (updated)
-

  3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
  src/main/python/apache/aurora/executor/executor_vars.py 
7665a77ca13bbbc337e345356b70f12357692f3d 
  src/main/python/apache/aurora/executor/gc_executor.py 
572c106038602b795a5b6bf08b2b85cf4b6bfec6 
  src/main/python/apache/thermos/core/helper.py 
9e4a8fb70df984d175129cb49025b3c222a64679 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
298459bab01d2c01bef1d69c1150ff2d5737ebbf 
  src/test/python/apache/thermos/core/test_helper.py 
58096119e1b412afa36a09da5759c5223a5b5d75 

Diff: https://reviews.apache.org/r/25466/diff/


Testing
---

Ran tests on OS X but not yet on Linux.  There is adequate coverage.

==edit, Linux test output==

src.test.python.apache.thermos.bin.test_thermos 
.   SUCCESS
src.test.python.apache.thermos.common.test_pathspec 
.   SUCCESS
src.test.python.apache.thermos.common.test_planner  
.   SUCCESS
src.test.python.apache.thermos.common.test_task_planner 
.   SUCCESS
src.test.python.apache.thermos.config.test_schema   
.   SUCCESS
src.test.python.apache.thermos.core.test_angry  
.   SUCCESS
src.test.python.apache.thermos.core.test_ephemerals 
.   SUCCESS
src.test.python.apache.thermos.core.test_failing_runner 
.   SUCCESS
src.test.python.apache.thermos.core.test_failure_limit  
.   SUCCESS
src.test.python.apache.thermos.core.test_finalization   
.   SUCCESS
src.test.python.apache.thermos.core.test_helper 
.   SUCCESS
src.test.python.apache.thermos.core.test_process
.   SUCCESS
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
src.test.python.apache.thermos.core.test_staged_kill
.   SUCCESS
src.test.python.apache.thermos.monitoring.test_disk 
.   SUCCESS
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS
src.test.python.apache.aurora.client.api.api
.   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator  
.   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher   
.   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
.   SUCCESS
src.test.python.apache.aurora.client.api.mux
.   SUCCESS
src.test.python.apache.aurora.client.api.quota_check
.   SUCCESS
src.test.python.apache.aurora.client.api.restarter  
.   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client   
.   SUCCESS
src.test.python.apache.aurora.client.api.sla
.   SUCCESS
src.test.python.apache.aurora.client.api.updater
.   SUCCESS
src.test.python.apache.aurora.client.api.updater_util   
.   SUCCESS
src.test.python.apache.aurora.client.binding_helper 
.   SUCCESS
src.test.python.apache.aurora.client.cli.api
.   SUCCESS
src.test.python.apache.aurora.client.cli.bridge 
.   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks  
.   SUCCESS
src.test.python.apache.aurora.client.cli.config 
.   SUCCESS
src.test.python.apache.aurora.client.cli.cron   
.   SUCCESS
src.test.python.apache.aurora.client.cli.help   
.   SUCCESS
src.test.python.apache.aurora.client.cli.inspect
.   SUCCESS
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.logging
.   SUCCESS
src.test.python.apache.aurora.client.cli.plugins

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-08 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review52674
---

Ship it!


awesome

- Joe Smith


On Sept. 8, 2014, 7:13 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25466/
> ---
> 
> (Updated Sept. 8, 2014, 7:13 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-412
> https://issues.apache.org/jira/browse/AURORA-412
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade Aurora to psutil 2.1.1
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7665a77ca13bbbc337e345356b70f12357692f3d 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 572c106038602b795a5b6bf08b2b85cf4b6bfec6 
>   src/main/python/apache/thermos/core/helper.py 
> 9e4a8fb70df984d175129cb49025b3c222a64679 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> 298459bab01d2c01bef1d69c1150ff2d5737ebbf 
>   src/test/python/apache/thermos/core/test_helper.py 
> 58096119e1b412afa36a09da5759c5223a5b5d75 
> 
> Diff: https://reviews.apache.org/r/25466/diff/
> 
> 
> Testing
> ---
> 
> Ran tests on OS X but not yet on Linux.  There is adequate coverage.
> 
> ==edit, Linux test output==
> 
> src.test.python.apache.thermos.bin.test_thermos   
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_pathspec   
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_planner
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_task_planner   
>   .   SUCCESS
> src.test.python.apache.thermos.config.test_schema 
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_angry
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_ephemerals   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_failing_runner   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_failure_limit
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_finalization 
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_helper   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_process  
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_runner_integration   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_staged_kill  
>   .   SUCCESS
> src.test.python.apache.thermos.monitoring.test_disk   
>   .   SUCCESS
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.cr

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-08 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/
---

(Updated Sept. 9, 2014, 2:13 a.m.)


Review request for Aurora, Joe Smith and Kevin Sweeney.


Bugs: AURORA-412
https://issues.apache.org/jira/browse/AURORA-412


Repository: aurora


Description
---

Upgrade Aurora to psutil 2.1.1


Diffs
-

  3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
  src/main/python/apache/aurora/executor/executor_vars.py 
7665a77ca13bbbc337e345356b70f12357692f3d 
  src/main/python/apache/aurora/executor/gc_executor.py 
572c106038602b795a5b6bf08b2b85cf4b6bfec6 
  src/main/python/apache/thermos/core/helper.py 
9e4a8fb70df984d175129cb49025b3c222a64679 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
298459bab01d2c01bef1d69c1150ff2d5737ebbf 
  src/test/python/apache/thermos/core/test_helper.py 
58096119e1b412afa36a09da5759c5223a5b5d75 

Diff: https://reviews.apache.org/r/25466/diff/


Testing (updated)
---

Ran tests on OS X but not yet on Linux.  There is adequate coverage.

==edit, Linux test output==

src.test.python.apache.thermos.bin.test_thermos 
.   SUCCESS
src.test.python.apache.thermos.common.test_pathspec 
.   SUCCESS
src.test.python.apache.thermos.common.test_planner  
.   SUCCESS
src.test.python.apache.thermos.common.test_task_planner 
.   SUCCESS
src.test.python.apache.thermos.config.test_schema   
.   SUCCESS
src.test.python.apache.thermos.core.test_angry  
.   SUCCESS
src.test.python.apache.thermos.core.test_ephemerals 
.   SUCCESS
src.test.python.apache.thermos.core.test_failing_runner 
.   SUCCESS
src.test.python.apache.thermos.core.test_failure_limit  
.   SUCCESS
src.test.python.apache.thermos.core.test_finalization   
.   SUCCESS
src.test.python.apache.thermos.core.test_helper 
.   SUCCESS
src.test.python.apache.thermos.core.test_process
.   SUCCESS
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
src.test.python.apache.thermos.core.test_staged_kill
.   SUCCESS
src.test.python.apache.thermos.monitoring.test_disk 
.   SUCCESS
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS
src.test.python.apache.aurora.client.api.api
.   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator  
.   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher   
.   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
.   SUCCESS
src.test.python.apache.aurora.client.api.mux
.   SUCCESS
src.test.python.apache.aurora.client.api.quota_check
.   SUCCESS
src.test.python.apache.aurora.client.api.restarter  
.   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client   
.   SUCCESS
src.test.python.apache.aurora.client.api.sla
.   SUCCESS
src.test.python.apache.aurora.client.api.updater
.   SUCCESS
src.test.python.apache.aurora.client.api.updater_util   
.   SUCCESS
src.test.python.apache.aurora.client.binding_helper 
.   SUCCESS
src.test.python.apache.aurora.client.cli.api
.   SUCCESS
src.test.python.apache.aurora.client.cli.bridge 
.   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks  
.   SUCCESS
src.test.python.apache.aurora.client.cli.config 
.   SUCCESS
src.test.python.apache.aurora.client.cli.cron   
.   SUCCESS
src.test.python.apache.aurora.client.cli.help   
.   SUCCESS
src.test.python.apache.aurora.client.cli.inspect
.   SUCCESS
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.logging
.   SUCCESS
src.test.python.apache.aurora.client.cli.plugins
.   SUCCESS

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-08 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review52662
---

Ship it!



src/main/python/apache/thermos/core/helper.py


proc and process seem synonymous, maybe s/proc/child/?



src/main/python/apache/thermos/monitoring/process_collector_psutil.py


s/proc/child/?


- Kevin Sweeney


On Sept. 8, 2014, 6:14 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25466/
> ---
> 
> (Updated Sept. 8, 2014, 6:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-412
> https://issues.apache.org/jira/browse/AURORA-412
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade Aurora to psutil 2.1.1
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7665a77ca13bbbc337e345356b70f12357692f3d 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 572c106038602b795a5b6bf08b2b85cf4b6bfec6 
>   src/main/python/apache/thermos/core/helper.py 
> 9e4a8fb70df984d175129cb49025b3c222a64679 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> 298459bab01d2c01bef1d69c1150ff2d5737ebbf 
>   src/test/python/apache/thermos/core/test_helper.py 
> 58096119e1b412afa36a09da5759c5223a5b5d75 
> 
> Diff: https://reviews.apache.org/r/25466/diff/
> 
> 
> Testing
> ---
> 
> Ran tests on OS X but not yet on Linux.  There is adequate coverage.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

5 matches

Site Navigation

Mail list logo

Footer information