Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/ --- (Updated Sept. 11, 2014, 9:08 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/#review53121 --- Ship it! Please add a TODO for test coverage. Testing this for

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/#review53129 --- Feel free to merge in this test case if it's to your liking:

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
On Sept. 11, 2014, 10:45 p.m., Bill Farner wrote: Feel free to merge in this test case if it's to your liking: https://github.com/wfarner/incubator-aurora/commit/a62f794c6052f6abfa53197dede7f6d21f80f4e4 Big thanks for the patch! Updated. - Maxim

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/ --- (Updated Sept. 12, 2014, 12:13 a.m.) Review request for Aurora and Bill