Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/#review53874 --- Ship it! Ship It! - Kevin Sweeney On Sept. 18, 2014, 2:29 p.m.,

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/ --- (Updated Sept. 18, 2014, 9:29 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/#review53733 --- Ship it! Ship It! - Joshua Cohen On Sept. 17, 2014, 5:49 p.m., D

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-17 Thread David McLaughlin
> On Sept. 17, 2014, 4:34 a.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 368 > > > > > > More objective? I don't want to kill the humor, but an objecti

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/ --- (Updated Sept. 17, 2014, 5:49 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/#review53651 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-16 Thread Bill Farner
> On Sept. 17, 2014, 12:52 a.m., Bill Farner wrote: > > > This is because the getJobSummary requests is 10KB compared to <1KB in > > > the sync version. > > > > I didn't grok this part. The _request_ is 10 KB? Nonetheless, why does > > sync/async change data representation in either directio

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-16 Thread David McLaughlin
> On Sept. 17, 2014, 12:52 a.m., Bill Farner wrote: > > > This is because the getJobSummary requests is 10KB compared to <1KB in > > > the sync version. > > > > I didn't grok this part. The _request_ is 10 KB? Nonetheless, why does > > sync/async change data representation in either directio

Re: Review Request 25721: Asynchronous JS for Scheduler UI

2014-09-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/#review53630 --- > This is because the getJobSummary requests is 10KB compared to <1K