Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/ --- (Updated Sept. 18, 2014, 11:13 a.m.) Review request for Aurora, Maxim

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-18 Thread Maxim Khutornenko
On Sept. 18, 2014, 12:56 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 152 https://reviews.apache.org/r/25760/diff/1/?file=693090#file693090line152 Technically, the outBytes may already be disposed at this point. Move return

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/ --- (Updated Sept. 18, 2014, 12:45 p.m.) Review request for Aurora, Maxim

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/ --- (Updated Sept. 18, 2014, 12:57 p.m.) Review request for Aurora, Maxim

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-18 Thread Kevin Sweeney
On Sept. 17, 2014, 5:56 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 152 https://reviews.apache.org/r/25760/diff/1/?file=693090#file693090line152 Technically, the outBytes may already be disposed at this point. Move return

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/#review53778 --- Ship it!

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

2014-09-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/#review53786 --- Ship it! LGTM mod Maxim's comments. - Bill Farner On Sept. 18,