Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25969/ --- (Updated Sept. 25, 2014, 5:03 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Bill Farner
> On Sept. 25, 2014, 12:04 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java, line 49 > > > > > > Should this be a RangeSet instead? I chose against this simply because it wa

Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25969/#review54483 --- Ship it! src/main/java/org/apache/aurora/scheduler/updater/JobDiff

Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25969/#review54442 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 24, 2014, 6:02 p.

Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25969/ --- (Updated Sept. 24, 2014, 6:02 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Bill Farner
> On Sept. 24, 2014, 4:58 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, > > line 195 > > > > > > s/_get_/_fetch_ to match method name. Fixed. > On Se

Re: Review Request 25969: When creating an update, store only the delta between the initial and desired states.

2014-09-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25969/#review54419 --- src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateSto