----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26048/#review54577 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On Sept. 25, 2014, 6:39 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26048/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 6:39 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Move the breadcumb to be under the nav (like on our public site) and make the > page title have consistent markup across pages. > > > Diffs > ----- > > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > 509639e122821057263703e7662c3e7d659d1c29 > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html > d305fb58c502dc4dba74fe8557752a5c86da9eb3 > > Diff: https://reviews.apache.org/r/26048/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > breadcrumb-after > > https://reviews.apache.org/media/uploaded/files/2014/09/25/0ca9cd6e-a742-40ca-b054-bd409bf66d2a__ui-breadcrumb.png > env page after > > https://reviews.apache.org/media/uploaded/files/2014/09/25/93794e00-6db7-48cd-85e6-6c1550e0957e__ui-env.png > role page after > > https://reviews.apache.org/media/uploaded/files/2014/09/25/2e4590ba-dec9-46a8-8d6e-dde0319e545e__ui-role.png > breadcrumb before > > https://reviews.apache.org/media/uploaded/files/2014/09/25/e37047de-56ee-4f48-91c3-a7f8741571de__ui-breadcrumb-before.png > role page before > > https://reviews.apache.org/media/uploaded/files/2014/09/25/f1fcc383-9757-4632-9dc6-334d7bfb457e__ui-role-before.png > env page before > > https://reviews.apache.org/media/uploaded/files/2014/09/25/a948b4cb-94d4-4e7b-86a9-ecf5d59ef901__ui-env-before.png > > > Thanks, > > David McLaughlin > >