Re: Review Request 26300: Sleep 10sec instead of 5sec during GC shutdown

2014-10-02 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55299
---

Ship it!


http://media.giphy.com/media/7LG6PqAubrWBa/giphy.gif

- Brian Wickman


On Oct. 3, 2014, 12:03 a.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26300/
 ---
 
 (Updated Oct. 3, 2014, 12:03 a.m.)
 
 
 Review request for Aurora, Vinod Kone and Brian Wickman.
 
 
 Bugs: AURORA-788
 https://issues.apache.org/jira/browse/AURORA-788
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Sleep 10sec instead of 5sec during GC shutdown
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/executor/gc_executor.py 
 44eb0da984a126536f0d277da3da128089201a47 
 
 Diff: https://reviews.apache.org/r/26300/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 26300: Sleep 10sec instead of 5sec during GC shutdown

2014-10-02 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55312
---


Upon discussion with Vinod Kone and Ben Mahler this doesn't seem like the right 
approach - driver.stop() doesn't actually send a signal to the slave that it 
should not expect further communications from the executor, so the race will 
always exist.

Upon further dissection of this code I'm questioning the need to quit after 15 
minutes of inactivity. Updated patch incoming.

- Kevin Sweeney


On Oct. 2, 2014, 5:03 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26300/
 ---
 
 (Updated Oct. 2, 2014, 5:03 p.m.)
 
 
 Review request for Aurora, Vinod Kone and Brian Wickman.
 
 
 Bugs: AURORA-788
 https://issues.apache.org/jira/browse/AURORA-788
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Sleep 10sec instead of 5sec during GC shutdown
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/executor/gc_executor.py 
 44eb0da984a126536f0d277da3da128089201a47 
 
 Diff: https://reviews.apache.org/r/26300/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Kevin Sweeney