Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-17 Thread Joshua Cohen
> On Oct. 16, 2014, 8:11 p.m., Kevin Sweeney wrote: > > Is this still needed? I thought the checkstyle check was updated > > Zameer Manji wrote: > I was under this impression as well. Ok, discarded. - Joshua --- This is an automati

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-16 Thread Zameer Manji
> On Oct. 16, 2014, 1:11 p.m., Kevin Sweeney wrote: > > Is this still needed? I thought the checkstyle check was updated I was under this impression as well. - Zameer --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review56991 --- Is this still needed? I thought the checkstyle check was updated -

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-16 Thread Joshua Cohen
> On Oct. 8, 2014, 6:02 p.m., Kevin Sweeney wrote: > > Apologies for the review delay. > > > > Is there a way we can tell checkstyle to avoid this file at all? I'd rather > > not make it a policy to patch each individual bower component we checkin. > > Joshua Cohen wrote: > Not without pat

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-08 Thread Joshua Cohen
> On Oct. 8, 2014, 6:02 p.m., Kevin Sweeney wrote: > > Apologies for the review delay. > > > > Is there a way we can tell checkstyle to avoid this file at all? I'd rather > > not make it a policy to patch each individual bower component we checkin. Not without patching checkstyle alas. - Jos

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55847 --- Apologies for the review delay. Is there a way we can tell checksty

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-08 Thread Joshua Cohen
> On Oct. 6, 2014, 4:33 p.m., Joshua Cohen wrote: > > *ping* Kevin. *ping* again. Once this ships the static assets changes from https://github.com/jcohen/incubator-aurora/commits/jcohen/static-assets (reviewed at https://reviews.apache.org/r/25835/) should be mergeable. - Joshua -

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55511 --- *ping* Kevin. - Joshua Cohen On Oct. 3, 2014, 4:51 p.m., Joshua C

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55356 --- Ship it! Ship It! - Brian Wickman On Oct. 3, 2014, 4:51 p.m., Jo