Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review57418 --- Ship it! Ship It! - David McLaughlin On Oct. 8, 2014, 11:56

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Mark Chu-Carroll
On Oct. 6, 2014, 12:44 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_update.py, lines 342-353 https://reviews.apache.org/r/26363/diff/1/?file=714123#file714123line342 This sequence of mocks and writing config to a file is repeated in... many (all?) of

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/ --- (Updated Oct. 8, 2014, 1:40 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Joshua Cohen
On Oct. 6, 2014, 4:44 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_update.py, lines 342-353 https://reviews.apache.org/r/26363/diff/1/?file=714123#file714123line342 This sequence of mocks and writing config to a file is repeated in... many (all?) of

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/ --- (Updated Oct. 8, 2014, 7:56 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55512 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55520 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 7:57 a.m.,