Re: Review Request 26753: Start removing clientv1.

2014-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/#review58215 --- This patch does not apply cleanly on master (53f4e73), do you need

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Mark Chu-Carroll
On Oct. 15, 2014, 2:24 p.m., Bill Farner wrote: Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a separte diff? Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's broken by this patch. I'd prefer to leave that doc - it's a historical

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/ --- (Updated Oct. 21, 2014, 2:05 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/ --- (Updated Oct. 21, 2014, 2:34 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Bill Farner
On Oct. 15, 2014, 6:24 p.m., Bill Farner wrote: Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a separte diff? Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's broken by this patch. Mark Chu-Carroll wrote: I'd prefer to

Re: Review Request 26753: Start removing clientv1.

2014-10-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/#review56756 --- Note: end-to-end tests are failing, but in the same way as they