Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor

2014-10-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/#review56951 --- Ship it! LGTM, i'm ambivalent to the stat name. - Bill Farner

Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor

2014-10-16 Thread Kevin Sweeney
On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote: LGTM, i'm ambivalent to the stat name. for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion - Kevin --- This is an automatically generated

Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor

2014-10-16 Thread Kevin Sweeney
On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote: LGTM, i'm ambivalent to the stat name. Kevin Sweeney wrote: for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion actually it's already inconsistent, and Joe's patch follows the majority