Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/#review56951 --- Ship it! LGTM, i'm ambivalent to the stat name. - Bill Farner On Oct. 16, 2014, 5:07 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/ --- (Updated Oct. 16, 2014, 5:07 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-843 https://issues.apache.org/jira/browse/AURORA-843 Repository: aurora Description --- Add a metric to count offers that do not provide sufficent resources to launch a GC Executor Diffs - src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1 Diff: https://reviews.apache.org/r/26809/diff/ Testing --- ./gradlew -Pq build Thanks, Joe Smith
Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote: LGTM, i'm ambivalent to the stat name. for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/#review56951 --- On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/ --- (Updated Oct. 16, 2014, 10:07 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-843 https://issues.apache.org/jira/browse/AURORA-843 Repository: aurora Description --- Add a metric to count offers that do not provide sufficent resources to launch a GC Executor Diffs - src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1 Diff: https://reviews.apache.org/r/26809/diff/ Testing --- ./gradlew -Pq build Thanks, Joe Smith
Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote: LGTM, i'm ambivalent to the stat name. Kevin Sweeney wrote: for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion actually it's already inconsistent, and Joe's patch follows the majority convention - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/#review56951 --- On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/ --- (Updated Oct. 16, 2014, 10:07 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-843 https://issues.apache.org/jira/browse/AURORA-843 Repository: aurora Description --- Add a metric to count offers that do not provide sufficent resources to launch a GC Executor Diffs - src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1 Diff: https://reviews.apache.org/r/26809/diff/ Testing --- ./gradlew -Pq build Thanks, Joe Smith
