Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review61324 --- Ship it! Master (f8040b9) is green with this patch. ./build-suppo

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/ --- (Updated Nov. 13, 2014, 10:19 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-11-13 Thread Bill Farner
> On Oct. 21, 2014, 1:25 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > lines 817-819 > > > > > > FWIW "|=" is a standard way to record boolean

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review58216 --- This patch does not apply cleanly on master (53f4e73), do you need t

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-20 Thread Maxim Khutornenko
> On Oct. 21, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 215 > > > > > > Mind renaming store to storeProvider? > > Bill Farner wrote: >

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review57512 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/ --- (Updated Oct. 21, 2014, 1:09 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-20 Thread Bill Farner
> On Oct. 21, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 215 > > > > > > Mind renaming store to storeProvider? I don't see any potential ris

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review57487 --- src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/#review57397 --- Ship it! Ship It! - Kevin Sweeney On Oct. 17, 2014, 4:01 p.m., B