Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/ --- (Updated Oct. 23, 2014, 10:58 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/#review58141 --- Ship it! Ship It! - Kevin Sweeney On Oct. 23, 2014, 3:02 p.m., M

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/#review58132 --- Ship it! Ship It! - Bill Farner On Oct. 23, 2014, 10:02 p.m., Ma

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/ --- (Updated Oct. 23, 2014, 10:02 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/ --- (Updated Oct. 23, 2014, 8:40 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

> On Oct. 22, 2014, 11:51 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_diff.py, line 60 > > > > > > While you're here, please change this to not use Mock, all down the > > hierarchy. > >

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

> On Oct. 22, 2014, 4:51 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_diff.py, line 60 > > > > > > While you're here, please change this to not use Mock, all down the > > hierarchy. > >

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

> On Oct. 22, 2014, 11:51 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_diff.py, line 60 > > > > > > While you're here, please change this to not use Mock, all down the > > hierarchy. > >

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/#review57939 --- In case you skimmed past it - the Mock thing would be great to addre

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/ --- (Updated Oct. 22, 2014, 11:59 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/#review57933 --- LG overall, aside for what seems to be unnecessary field modificatio

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

> On Oct. 22, 2014, 9:58 p.m., Bill Farner wrote: > > Is it worth the risk to update the client code now? Seems like we can ride > > it out until the field is removed with lower overall risk. If not done now the client diff will be immediately broken as a new TaskConfig.key field will never b

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/#review57915 --- Is it worth the risk to update the client code now? Seems like we c

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/ --- (Updated Oct. 22, 2014, 9:10 p.m.) Review request for Aurora, Kevin Sweeney and