Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

2014-10-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/ --- (Updated Oct. 22, 2014, 4 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

2014-10-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/#review57662 --- Ship it! Ship It! - Kevin Sweeney On Oct. 21, 2014, 2:24 p.m.,

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

2014-10-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/#review57723 --- Ship it!

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

2014-10-21 Thread Kevin Sweeney
On Oct. 21, 2014, 6:40 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java, line 150 https://reviews.apache.org/r/26997/diff/1/?file=728016#file728016line150 Consider sticking to the standard here of using guava's ToStringHelper