Re: Review Request 27009: Use virtualenv to build pants instead of pex.

2014-10-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/ --- (Updated Oct. 22, 2014, 2:14 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

2014-10-22 Thread Kevin Sweeney
> On Oct. 22, 2014, 2:06 p.m., Bill Farner wrote: > > pants, line 16 > > > > > > Why allow unset? Virtualenv's activate script doesn't work under -o nounset. - Kevin

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

2014-10-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/#review57843 --- Ship it! Please file a PEX bug about the behaviour you noticed as w

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

2014-10-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/ --- (Updated Oct. 22, 2014, 11:05 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

2014-10-22 Thread Kevin Sweeney
> On Oct. 22, 2014, 10:59 a.m., Zameer Manji wrote: > > pants, line 40 > > > > > > Why do we need to do this? We don't - removed. - Kevin --- This is an autom

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

2014-10-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/#review57837 --- pants Why d