Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Bill Farner
On Oct. 28, 2014, 2:01 a.m., Aurora ReviewBot wrote: Master (9fb2ce4) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58825 ---

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Maxim Khutornenko
On Oct. 28, 2014, 5:04 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, line 67 https://reviews.apache.org/r/27262/diff/1/?file=734815#file734815line67 Is the cargo cult of the code below necessary? I was hestitant to invest more

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/ --- (Updated Oct. 28, 2014, 5:22 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58828 ---

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58832 --- Master (9fb2ce4) is red with this patch.

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/ --- (Updated Oct. 28, 2014, 6:01 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Maxim Khutornenko
On Oct. 28, 2014, 5:30 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, line 129 https://reviews.apache.org/r/27262/diff/2/?file=735497#file735497line129 Can you fully centralize the backfill and the counter increment?

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58843 --- Ship it! Master (9fb2ce4) is green with this patch.

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Bill Farner
On Oct. 28, 2014, 5:30 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, line 129 https://reviews.apache.org/r/27262/diff/2/?file=735497#file735497line129 Can you fully centralize the backfill and the counter increment?

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Maxim Khutornenko
On Oct. 28, 2014, 5:30 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, line 129 https://reviews.apache.org/r/27262/diff/2/?file=735497#file735497line129 Can you fully centralize the backfill and the counter increment?

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/ --- (Updated Oct. 28, 2014, 8:26 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58860 --- Ship it! Master (9fb2ce4) is green with this patch.

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58861 --- Ship it! - Bill Farner On Oct. 28, 2014, 8:26 p.m., Maxim

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58754 --- Master (9fb2ce4) is red with this patch.