Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/ --- (Updated Nov. 3, 2014, 6:52 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
> On Nov. 3, 2014, 6:38 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java, line 16 > > > > > > java.util.Objects Done. > On Nov. 3, 2014, 6:38 p.m., Kevin Sweeney wrote: >

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review59610 --- Ship it! Ship It! - Bill Farner On Oct. 30, 2014, 5:11 p.m., Max

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review58937 --- Ship it! src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review59599 --- Ping. - Maxim Khutornenko On Oct. 30, 2014, 5:11 p.m., Maxim Khut

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review59229 --- Master (d85e616) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-10-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/ --- (Updated Oct. 30, 2014, 5:11 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-10-30 Thread Maxim Khutornenko
> On Oct. 30, 2014, 4:16 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 420 > > > > > > Is there a reason we don't use `Resources` here? Seems like you could > >

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-10-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review59208 --- Please excuse me if this seems like nit-picking, i'm just searching

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-10-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review58936 --- Master (978998a) is red with this patch. ./build-support/jenkins/b