Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59223 --- Ship it! Master (d85e616) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 4:39 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 30, 2014, 4:39 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p1 src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p2 src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p3 src/resources/org/apache/thermos/root/checkpoints/failure/runner src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.a src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.b src/resources/org/apache/thermos/root/checkpoints/failure_limit/runner src/resources/org/apache/thermos/root/checkpoints/hello_world/coordinator.echo src/resources/org/apache/thermos/root/checkpoints/hello_world/runner src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_one src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_three src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_two src/resources/org/apache/thermos/root/checkpoints/ordering/runner src/resources/org/apache/thermos/root/checkpoints/ports/coordinator.echo src/resources/org/apache/thermos/root/checkpoints/ports/runner src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/coordinator.sleep src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/runner src/resources/org/apache/thermos/root/checkpoints/sleep60/coordinator.sleep src/resources/org/apache/thermos/root/checkpoints/sleep60/runner src/resources/org/apache/thermos/root/logs/failure/p1/0/stdout src/resources/org/apache/thermos/root/logs/failure/p2/0/stdout src/resources/org/apache/thermos/root/logs/failure/p2/1/stdout src/resources/org/apache/thermos/root/logs/failure/p3/0/stdout src/resources/org/apache/thermos/root/logs/failure/p3/1/stdout src/resources/org/apache/thermos/root/logs/failure/p3/2/stdout src/resources/org/apache/thermos/root/logs/failure_limit/a/0/stdout src/resources/org/apache/thermos/root/logs/hello_world/echo/0/stdout src/resources/org/apache/thermos/root/logs/ordering/echo_one/0/stdout src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout src/resources/org/apache/thermos/root/sandbox/p1 src/resources/org/apache/thermos/root/sandbox/p2 src/resources/org/apache/thermos/root/sandbox/p3 src/resources/org/apache/thermos/root/tasks/active/sleep60-lost src/resources/org/apache/thermos/root/tasks/finished/failure src/resources/org/apache/thermos/root/tasks/finished/failure_limit src/resources/org/apache/thermos/root/tasks/finished/hello_world src/resources/org/apache/thermos/root/tasks/finished/ordering src/resources/org/apache/thermos/root/tasks/finished/ports src/resources/org/apache/thermos/root/tasks/finished/sleep60 src/test/python/apache/aurora/executor/test_gc_executor.py 85afe502fd6daa2d481f4348470b4303b88c5909 src/test/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59072 --- Ship it! Ship It! - Kevin Sweeney On Oct. 29, 2014, 4:19 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 4:19 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59076 --- Ship it! Master (6b30cf7) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Oct. 29, 2014, 11:19 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:19 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59080 --- Would this be a good time to suggest moving these to src/test/resources to match other conventions? As far as I can tell it should be a quick sed one-liner. - Kevin Sweeney On Oct. 29, 2014, 4:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 4:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59081 --- Ship it! Master (6b30cf7) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Oct. 29, 2014, 11:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
On Oct. 29, 2014, 11:49 p.m., Kevin Sweeney wrote: Would this be a good time to suggest moving these to src/test/resources to match other conventions? As far as I can tell it should be a quick sed one-liner. +1 - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59080 --- On Oct. 29, 2014, 11:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59111 --- Ship it! Ship It! - Jake Farrell On Oct. 29, 2014, 11:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira/browse/AURORA-711 Repository: aurora Description --- Document thermos checkpoint files, include them in git archives. Diffs - .gitattributes 8d50d053e8aa5f4e54fc85c687f9869875d22e09 docs/test-resource-generation.md PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/README PRE-CREATION Diff: https://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner
