Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-31 Thread Bill Farner
On Oct. 30, 2014, 5 p.m., Joshua Cohen wrote: src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java, line 58 https://reviews.apache.org/r/27371/diff/1/?file=742675#file742675line58 Each test is invoking this method, then accessing the injector instance var.

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-31 Thread Bill Farner
On Oct. 30, 2014, 3:48 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 212 https://reviews.apache.org/r/27371/diff/1/?file=742673#file742673line212 s/public// Done. I also realized the constructor injection was a hack,

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-31 Thread Bill Farner
On Oct. 30, 2014, 5:29 p.m., Kevin Sweeney wrote: buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line 89 https://reviews.apache.org/r/27371/diff/1/?file=742671#file742671line89 looks like your sentence got cut off here - the legacyClassesWithoutCoverage

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-31 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/ --- (Updated Oct. 31, 2014, 8:31 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59412 --- Ship it! Master (02a1c04) is green with this patch.

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59206 --- Ship it!

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59224 --- Ship it!

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59232 --- Ship it!

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59140 --- Ship it! Master (d85e616) is green with this patch.