Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files
On Nov. 4, 2014, 7:54 p.m., Bill Farner wrote: Ship It! Thanks! This is now on master: $ git log -1 origin/master commit 5250a94da3b8f7ea72f6014fb586a1c06ecd83c1 Author: Joshua Cohen jco...@twopensource.com Date: Thu Nov 6 12:49:52 2014 -0800 Replace twitter.commons.io.FileUtils dependency w/ guava's Files Reviewed at https://reviews.apache.org/r/27545/ - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59814 --- On Nov. 3, 2014, 11:09 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/ --- (Updated Nov. 3, 2014, 11:09 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Replace twitter.commons.io.FileUtils dependency w/ guava's Files Diffs - build.gradle a68de0ddc29f7a8e7b0ab6b83a7542a2527c91cd src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 91a92c6da09dc621db0b549f463d3a5c360efe6c src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 3a3c95e0a2a7fe3ea1a95b8a9ee5e2702ce67037 Diff: https://reviews.apache.org/r/27545/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59814 --- Ship it! Ship It! - Bill Farner On Nov. 3, 2014, 11:09 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/ --- (Updated Nov. 3, 2014, 11:09 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Replace twitter.commons.io.FileUtils dependency w/ guava's Files Diffs - build.gradle a68de0ddc29f7a8e7b0ab6b83a7542a2527c91cd src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 91a92c6da09dc621db0b549f463d3a5c360efe6c src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 3a3c95e0a2a7fe3ea1a95b8a9ee5e2702ce67037 Diff: https://reviews.apache.org/r/27545/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59675 --- Master (9ef905a) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . FAILURE - Aurora ReviewBot On Nov. 3, 2014, 11:09 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/ --- (Updated Nov. 3, 2014, 11:09 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Replace twitter.commons.io.FileUtils dependency w/ guava's Files Diffs - build.gradle a68de0ddc29f7a8e7b0ab6b83a7542a2527c91cd src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 91a92c6da09dc621db0b549f463d3a5c360efe6c src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 3a3c95e0a2a7fe3ea1a95b8a9ee5e2702ce67037 Diff: https://reviews.apache.org/r/27545/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59677 --- Ship it! Ship It! - Kevin Sweeney On Nov. 3, 2014, 3:09 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/ --- (Updated Nov. 3, 2014, 3:09 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Replace twitter.commons.io.FileUtils dependency w/ guava's Files Diffs - build.gradle a68de0ddc29f7a8e7b0ab6b83a7542a2527c91cd src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 91a92c6da09dc621db0b549f463d3a5c360efe6c src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 3a3c95e0a2a7fe3ea1a95b8a9ee5e2702ce67037 Diff: https://reviews.apache.org/r/27545/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
