Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

> On Nov. 6, 2014, 2:15 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/client/cli/test_cron.py, line 143 > > > > > > instance=True? Obviated in latest diff. - Bill ---

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60094 --- Ship it! Ship It! - Kevin Sweeney On Nov. 5, 2014, 4:47 p.m., Bi

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60063 --- src/test/python/apache/aurora/client/cli/test_cron.py

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60080 --- Ship it! Master (0ad2fca) is green with this patch. ./build-suppo

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60078 --- Ship it! Ship It! - Zameer Manji On Nov. 5, 2014, 4:47 p.m., Bil

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

> On Nov. 5, 2014, 11:57 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/client/commands/test_create.py, line 68 > > > > > > Don't we want to remove spec_set=[] ? They are now converted to `spec_set=False`,

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/ --- (Updated Nov. 6, 2014, 12:47 a.m.) Review request for Aurora, Kevin Sweeney, Ma

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60068 --- Ship it! Master (0ad2fca) is green with this patch. ./build-suppo

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60062 --- src/test/python/apache/aurora/client/commands/test_create.py

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/ --- (Updated Nov. 5, 2014, 11:53 p.m.) Review request for Aurora, Kevin Sweeney, Ma

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/ --- (Updated Nov. 5, 2014, 11:37 p.m.) Review request for Aurora, Kevin Sweeney, Ma

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60027 --- src/test/python/apache/aurora/client/api/test_api.py

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review60022 --- Master (98a4f42) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

> On Nov. 5, 2014, 6:52 p.m., Joshua Cohen wrote: > > I know this was mostly automated, but how do you feel about creating a > > helper for the create_autospec call since it seems like every instance > > passes the same values for spec_set and instance? That crossed my mind early on. There's

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/ --- (Updated Nov. 5, 2014, 7:42 p.m.) Review request for Aurora, Kevin Sweeney, Max

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

> On Nov. 5, 2014, 7:11 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/client/cli/test_inspect.py, line 31 > > > > > > I don't think we need to use a mock here, why can't we just create the > > Pystachio o

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

> On Nov. 5, 2014, 6:52 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 183 > > > > > > Debug cruft? Kill? Heh thanks, removed. > On Nov. 5, 2014, 6:52 p.m., Joshua Cohen wrote

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review5 --- src/test/python/apache/aurora/client/cli/test_inspect.py

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review59991 --- I know this was mostly automated, but how do you feel about creating

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628/#review59990 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/b