Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/ --- (Updated Nov. 6, 2014, 6:40 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/ --- (Updated Nov. 6, 2014, 6:41 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/#review60293 --- Ship it! Master (5250a94) is green with this patch.

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Kevin Sweeney
On Nov. 6, 2014, 6:34 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java, lines 64-69 https://reviews.apache.org/r/27716/diff/1/?file=754191#file754191line64 The method is gone but the doc stays? If so, needs revisiting

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/ --- (Updated Nov. 6, 2014, 7:40 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/#review60299 --- Master (5250a94) is red with this patch.

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/ --- (Updated Nov. 6, 2014, 7:46 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/#review60300 --- Ship it! Master (5250a94) is green with this patch.